feat(ads): ad reward tracking support - #1890
Open
peterporfy wants to merge 4 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9991b36. Configure here.
AlvaroBrey
approved these changes
Aug 18, 2026
AlvaroBrey
left a comment
AlvaroBrey
left a comment
Contributor
There was a problem hiding this comment.
looks good, just one question
| methodNotSupportedOnWeb('generateRewardVerificationToken'); | ||
| }, | ||
| pollRewardVerification: async (_clientTransactionId: string) => { | ||
| pollRewardVerification: async (_clientTransactionId: string, _trackingMetadata?: any) => { |
Contributor
There was a problem hiding this comment.
q: why any, if there's a RewardedAdTrackingMetadata definition below (whose doc says it's for this fun)
Contributor
Author
There was a problem hiding this comment.
There is no reason for this to be any. Changed it: b4647de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes the ad reward tracking functionality - which is just a new parameter for the polling function.
Do not merge until android and ios sdks are released with the feature.
Note
Medium Risk
Touches rewarded-ad verification and analytics plumbing on native bridges; behavior depends on unreleased iOS/Android SDKs, but the API change is backward compatible.
Overview
Adds optional rewarded-ad tracking when polling reward verification:
Purchases.pollRewardVerificationnow accepts a second argument,trackingMetadata, so the native SDK can automatically emit reward-verification analytics for that ad.Introduces the beta
RewardedAdTrackingMetadatatype (mediator, format, ad unit, impression id, optional network/placement) and forwards it through the React Native bridge on iOS and Android, plus the web/browser stub signature. Existing one-argument calls stay valid; apitesters cover the new overload.Reviewed by Cursor Bugbot for commit 4308157. Bugbot is set up for automated code reviews on this repo. Configure here.