AGENTS.md and CODE_STYLE.md 2026 August update - #4148
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
…26 code style updates - New custom detekt rule: RedundantJvmNameWithSynthetic Flags @JvmName on declarations already marked @JvmSynthetic, since @JvmSynthetic hides the member from Java entirely. - AGENTS.md Code Style: Test every new code path - AGENTS.md Code Style: iOS naming parity - AGENTS.md Code Style: KDoc only for non-obvious behavior Co-authored-by: Cesar de la Vega <vegaro@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4148 +/- ##
=======================================
Coverage 83.50% 83.50%
=======================================
Files 451 451
Lines 18146 18146
Branches 2737 2737
=======================================
Hits 15152 15152
Misses 2106 2106
Partials 888 888 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
Monthly guardrails update based on PR review feedback analysis.
Description
Summary
Analyzed 1,187 comments across 243 pull requests from August 2026 (2026-08-01 to 2026-08-31) in RevenueCat/purchases-android. Comments came from 19 human reviewers (tonidero, AlvaroBrey, vegaro, rickvdl, facumenzella, peterporfy, ajpallares, polmiro, JayShortway, fire-at-will, JZDesign, MonikaMateska, TheRogue76, guillemcorominas, cyrilmottier, Climbatize, gurgen-k-y) and 4 bots (cursor[bot], copilot-pull-request-reviewer[bot], codecov[bot], emerge-tools[bot]).
New guidelines added
RedundantJvmNameWithSyntheticdetekt rule — Flags@JvmNameon declarations already marked@JvmSynthetic(the latter hides the member from Java entirely, making@JvmNameuseless)@JvmNameannotations after Kotlin-only migrationpurchases-iostype and property names unless Kotlin conventions require otherwiseTest plan
./gradlew :detekt-rules:test— all 12 tests pass (4 new forRedundantJvmNameWithSynthetic+ 8 existing)./gradlew detektAll— passes with zero violations (no existing code matches the new rule)