Skip to content

feat(admob): demonstrate banner ads - #4095

Merged
polmiro merged 3 commits into
next-gen-admob-sdkfrom
next-gen-admob-sample-banner
Sep 1, 2026
Merged

feat(admob): demonstrate banner ads#4095
polmiro merged 3 commits into
next-gen-admob-sdkfrom
next-gen-admob-sample-banner

Conversation

@polmiro

@polmiro polmiro commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

Expands the Google Mobile Ads Next-Gen example app with banner workflows:

  • add direct and preloaded banner workflows
  • reset rendered banner state when switching load modes
  • demonstrate registration and refresh callbacks

Screenshots

Banner direct-loading screen


Note

Low Risk
Sample-app and documentation changes only; no production SDK or auth/data-path changes.

Overview
Replaces the Banner placeholder in the AdMob Next-Gen sample with a working Banner screen that shows RevenueCat-tracked banner flows end to end.

Direct mode loads into an AdView via loadAndTrackAd, with status for load success/failure plus impression, click, and refresh callbacks. Preloaded mode uses the shared preloader UI to start/stop buffering, then poll + register a buffered ad on the same view with distinct placements (banner_direct, banner_preload, banner_poll). Switching load modes recreates the AdView (key(mode)) and resets status so banner state does not leak across modes.

The sample README Coverage line for banners is updated to describe lifecycle/refresh callbacks instead of callback-replacement wording.

Reviewed by Cursor Bugbot for commit 1035d0b. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4c5a2c8. Configure here.

@polmiro
polmiro force-pushed the next-gen-admob-sample-banner branch from 4c5a2c8 to 09fc0d5 Compare September 1, 2026 08:12
@emerge-tools

emerge-tools Bot commented Sep 1, 2026

Copy link
Copy Markdown

📸 Snapshot Test

1 modified, 620 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility Paparazzi
com.revenuecat.testpurchasesuiandroidcompatibility.paparazzi
0 0 0 0 282 0 N/A
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility
0 0 1 0 338 0 ✅ Approved

🛸 Powered by Emerge Tools

@polmiro
polmiro requested a review from AlvaroBrey September 1, 2026 08:42
Base automatically changed from next-gen-admob-sample-preloader-ui to next-gen-admob-sdk September 1, 2026 08:46
@polmiro
polmiro force-pushed the next-gen-admob-sample-banner branch from 09fc0d5 to 1035d0b Compare September 1, 2026 08:46
@polmiro
polmiro merged commit f5ad3ff into next-gen-admob-sdk Sep 1, 2026
34 checks passed
@polmiro
polmiro deleted the next-gen-admob-sample-banner branch September 1, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants