refactor(admob): reuse suspended load tracking for interstitial ads - #4086
Merged
polmiro merged 1 commit intoAug 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next-gen-admob-sdk #4086 +/- ##
======================================================
- Coverage 83.01% 82.99% -0.02%
======================================================
Files 437 437
Lines 17893 17893
Branches 2684 2684
======================================================
- Hits 14854 14851 -3
- Misses 2146 2148 +2
- Partials 893 894 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Going ahead merging this one since it was an oversight and practically the same commit is being applied in every ad format branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I jumped the gun and merged the approved PR for interstitial ads before adopting the new helper.
AdLoadResult.trackAndConfigureAdLoadResultfoundation helper.Test plan
./gradlew :feature:admob-next-gen:testDefaultsDebugUnitTest./gradlew detektAll./scripts/api-check.shNote
Low Risk
Mechanical refactor to a shared helper with equivalent tracking and callback wiring; no API or auth changes.
Overview
The suspending
AdTracker.loadAndTrackInterstitialAdpath no longer inlines success/failure tracking withtrackAdLoaded/trackAdFailedToLoad. It now chainsInterstitialAd.loadthrough the sharedtrackAndConfigureAdLoadResulthelper (from #4053), passing interstitial format metadata and aconfigureAdblock that installs the tracking event callback.Behavior is intended to stay the same: the original
AdLoadResultis returned, load success/failure events are still tracked, and tracking is installed on successful loads before the suspend function completes.Reviewed by Cursor Bugbot for commit 9a4b7f0. Bugbot is set up for automated code reviews on this repo. Configure here.