fix(ci): retry flaky Maestro workflow tests - #4032
Open
circleci-app[bot] wants to merge 2 commits into
Open
Conversation
The workflow_config_killswitch_mid_session flow intermittently fails with "Unable to launch app com.revenuecat.e2etests" (2s, no UI rendered) while all other 12 flows pass. This is a transient emulator cold-start race — the fix adds --retries 2 so Maestro automatically re-runs a failed flow before reporting it as a CI failure. AI-Generated: true
Generated by 🚫 Danger |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a3f193f. Configure here.
| name: Run Maestro workflow tests | ||
| command: | | ||
| maestro test --format junit --output maestro/workflow-report.xml maestro/workflows/ | ||
| maestro test --retries 2 --format junit --output maestro/workflow-report.xml maestro/workflows/ |
Contributor
There was a problem hiding this comment.
Invalid Maestro retries flag
High Severity
maestro test --retries 2 is not a documented local CLI option, so this job is likely to fail immediately with an unknown-option error instead of retrying the flaky kill-switch flow. Official Maestro retries are the YAML retry command (or a shell re-run of failed flows), not a global --retries flag.
Reviewed by Cursor Bugbot for commit a3f193f. Configure here.
polmiro
force-pushed
the
draft-banner-pr-alignment
branch
2 times, most recently
from
August 26, 2026 10:08
ed2009d to
2fb60b8
Compare
Base automatically changed from
draft-banner-pr-alignment
to
next-gen-admob-sdk
August 26, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
workflow_config_killswitch_mid_sessionMaestro flow with "Unable to launch app com.revenuecat.e2etests" (2s duration) while all 12 other flows passedassertVisibleimmediately afterlaunchApp(no extended timeout), making it slightly more sensitive to the first-launch slow path--retries 2to themaestro testcommand so any transiently-failing flow is automatically retried before being reported as a CI failureTest plan
run-maestro-workflow-testsCI job passes on this branchmaestro test --retries 2is valid for the installed Maestro version (it is;--retrieshas been supported since Maestro 1.32)https://app.circleci.com/agents/gh/RevenueCat/chat/d330a74c-b4fa-431c-b5eb-1ef4ca59aa01
Note
Low Risk
CI-only change to Maestro retry flags; no production or SDK code affected.
Overview
Adds
--retries 2to themaestro testinvocation in therun-maestro-workflow-testsCircleCI job so transient emulator/app launch failures are retried before the job fails.JUnit output path and workflow directory are unchanged; only the workflow Maestro job is updated (not
run-maestro-e2e-tests).Reviewed by Cursor Bugbot for commit a3f193f. Bugbot is set up for automated code reviews on this repo. Configure here.