Superseded: next-gen interstitial extensions - #3959
Closed
polmiro wants to merge 8 commits into
Closed
Conversation
2 tasks
polmiro
force-pushed
the
add-next-gen-admob-event-tracking
branch
from
August 13, 2026 09:27
e627f80 to
ef97952
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## add-next-gen-admob-event-tracking #3959 +/- ##
==================================================================
Coverage 82.74% 82.74%
==================================================================
Files 429 429
Lines 17572 17572
Branches 2657 2657
==================================================================
Hits 14540 14540
Misses 2139 2139
Partials 893 893 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
polmiro
force-pushed
the
add-next-gen-admob-event-tracking
branch
from
August 13, 2026 10:16
ef97952 to
c4cbcd7
Compare
polmiro
force-pushed
the
add-next-gen-admob-banner-interstitial
branch
3 times, most recently
from
August 17, 2026 08:33
4eef8bb to
74ad4e5
Compare
polmiro
force-pushed
the
add-next-gen-admob-event-tracking
branch
6 times, most recently
from
August 17, 2026 10:09
4c43a26 to
b9ca3d1
Compare
polmiro
force-pushed
the
add-next-gen-admob-banner-interstitial
branch
from
August 17, 2026 10:29
74ad4e5 to
b64c6d1
Compare
The flow tests asserted callback wiring and delegation but never installed a Purchases singleton, so trackIfConfigured short-circuited on every path and the load-time tracking arguments went unchecked. The wrapper classes are covered in TrackingAdEventCallbackTest, but nothing pinned what the banner and interstitial entry points hand to TrackingAdLoadCallback: swapping AdFormat.BANNER for INTERSTITIAL, dropping the placement, or not reading adUnitId off the request all kept the suite green.
The generated AdViewExtensionsKt-style names were leaking into api.txt and Dokka. Follow feature/admob's @file:JvmName convention, keeping NextGen in each name so the facades stay unambiguous next to the legacy module's.
polmiro
marked this pull request as ready for review
August 17, 2026 11:48
polmiro
marked this pull request as draft
August 17, 2026 15:38
polmiro
force-pushed
the
add-next-gen-admob-banner-interstitial
branch
from
August 17, 2026 16:07
b64c6d1 to
7bc7fc7
Compare
polmiro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #3985 after renaming the head branch to reflect the interstitial-only scope.