fix(ci): use canonical RevealFleet signer configuration - #511
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prove-red owner exception now reads only
REVEALFLEET_OVERRIDE_SIGNERS, matching the canonical fleet identity. All three language jobs inject that repository variable. An obsolete-only setting cannot grant an exception, and both the canonical and obsolete variables are removed before changed tests execute.The existing shared signature verifier, exact repository/PR/head/gate/expiry context, request-label ordering and signature namespace remain unchanged. Regression coverage exercises the real CLI and installed shared verifier with synthetic signatures: canonical trust succeeds despite conflicting obsolete data, obsolete-only trust fails closed, and invalid canonical trust cannot fall back. Workflow assertions cover TypeScript, Go and Rust. Owned Git fixtures clear inherited repository-local Git state and prove an unrelated index remains untouched.
Validation:
pnpm lint: passed across 437 files; five existing warnings and one existing informational diagnostic in unchanged files.pnpm lint:docsandgit diff --check: passed.Sandbox runs could not spawn fixture Git/SSH or lint subprocesses (EPERM); unchanged commands passed with permitted execution outside the sandbox. One initial new fixture assertion incorrectly expected the disposable prove-red checkout to restore source; the fixture now resets its owned source before each case and verifies the existing base-source behavior.
The repository owner still needs to provision and verify the canonical public signer configuration in Actions. Source tests do not establish external variable availability or a live CI grant. This change does not alter repository settings, publish a grant, use an owner exception key, or modify provider configuration.