Conversation
iOS Safari(含 standalone PWA)的 text autosizing 機制會依欄寬/裝置寬比例 在渲染時額外放大文字,不反映在 getComputedStyle().fontSize,既有的 inline font-size 覆寫蓋不掉。epub.js 分頁排版是窄欄 CSS columns,特別 容易觸發。注入 text-size-adjust: 100% 關閉此行為。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe reader adds ChangesReader text-size adjustment override
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant useReaderEngine
participant EPUBContentDocument
participant applyTextSizeAdjustOverride
useReaderEngine->>EPUBContentDocument: Initialize loaded EPUB content
useReaderEngine->>applyTextSizeAdjustOverride: Apply override to document
applyTextSizeAdjustOverride->>EPUBContentDocument: Inject text-size-adjust CSS
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS Safari(含 standalone PWA)的 text autosizing 機制會依欄寬/裝置寬比例 在渲染時額外放大文字,不反映在 getComputedStyle().fontSize,既有的
inline font-size 覆寫蓋不掉。epub.js 分頁排版是窄欄 CSS columns,特別 容易觸發。注入 text-size-adjust: 100% 關閉此行為。
Summary by CodeRabbit