Fix HCSpellList lookup for hardcore trainer skip#358
Open
FailMaven wants to merge 2 commits into
Open
Conversation
fixed spell list
nicaodl2
reviewed
Jun 10, 2026
| [20755] = true, -- create soulstone r3 | ||
| [20756] = true, -- create soulstone r4 | ||
| [20757] = true, -- create soulstone r5 | ||
| [1949] = true, -- hellfire r1 |
There was a problem hiding this comment.
Hey. Why would you not train this? Hellfire is definitely used in HC.
Author
There was a problem hiding this comment.
It's what was there originally. I only fixed the issues with the spells not actually being flagged (and added R1 ss). Tho to be fair, I'd never use Hellfire in hardcore. It's too scary to me, ha ha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HCSpellListfrom array syntax to keyed[spellId] = trueentries soHCSpellList[spellId]lookups inProcessSpellsactually work693) to the hardcore skip list (trained at level 18)Context
v4.10.13 (
c50dc0b) switched hardcore trainer logic toC_GameRules.IsHardcoreActive(), butHCSpellListinDB/classic/spells.luawas unchanged. Entries like20752,are stored at numeric indices1..n, not as keys — soHCSpellList[20752]was alwaysniland listed spells were still auto-purchased on HC servers.Test plan
693) is not auto-bought20752+) are not auto-bought