Skip to content

Fix HCSpellList lookup for hardcore trainer skip#358

Open
FailMaven wants to merge 2 commits into
RestedXP:mainfrom
FailMaven:FailMaven-patch-1
Open

Fix HCSpellList lookup for hardcore trainer skip#358
FailMaven wants to merge 2 commits into
RestedXP:mainfrom
FailMaven:FailMaven-patch-1

Conversation

@FailMaven

Copy link
Copy Markdown

Summary

  • Convert HCSpellList from array syntax to keyed [spellId] = true entries so HCSpellList[spellId] lookups in ProcessSpells actually work
  • Add Soulstone rank 1 (693) to the hardcore skip list (trained at level 18)

Context

v4.10.13 (c50dc0b) switched hardcore trainer logic to C_GameRules.IsHardcoreActive(), but HCSpellList in DB/classic/spells.lua was unchanged. Entries like 20752, are stored at numeric indices 1..n, not as keys — so HCSpellList[20752] was always nil and listed spells were still auto-purchased on HC servers.

Test plan

  • On a Hardcore Classic Era warlock with trainer automation enabled, open a class trainer at level 18+ and confirm Soulstone (693) is not auto-bought
  • At level 30+, confirm Create Soulstone ranks (20752+) are not auto-bought
  • On a non-HC server (or with trainer automation off), confirm normal trainer behavior is unchanged
  • Confirm Hellfire / Reincarnation skips still work on HC

Comment thread DB/classic/spells.lua
[20755] = true, -- create soulstone r3
[20756] = true, -- create soulstone r4
[20757] = true, -- create soulstone r5
[1949] = true, -- hellfire r1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Why would you not train this? Hellfire is definitely used in HC.

@FailMaven FailMaven Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what was there originally. I only fixed the issues with the spells not actually being flagged (and added R1 ss). Tho to be fair, I'd never use Hellfire in hardcore. It's too scary to me, ha ha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants