Homepage hub: Activity / Fund / Proposals shared shell - #983
Homepage hub: Activity / Fund / Proposals shared shell#983nicktytarenko wants to merge 3 commits into
Conversation
Move Activity, Fund, and Proposals under a persistent (home) layout with HomeTabs and FundSidebar so tab switches only swap the feed slot. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b910ee775
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export type FundTab = 'activity' | 'fund' | 'proposals'; | ||
|
|
||
| /** Routes that make up the homepage hub — all of them highlight "Home" in the nav. */ | ||
| export const HOME_TAB_PATHS = ['/', '/fund', '/fund/proposals']; |
There was a problem hiding this comment.
Update Home nav for the new Activity hub
Now that / is defined as the Activity tab in the homepage hub, the app-level Home navigation still sends users to the legacy feed routes (/for-you for logged-in users and /popular for logged-out users in app/layouts/Navigation.tsx, with the same pattern in the mobile bottom nav). Because those routes still exist and there is no redirect for them in next.config.js, users who click Home from the primary nav never reach this new hub; on desktop, / also is not marked active by the Home nav item. Update those nav href/active checks alongside this route list so the new Activity hub is actually reachable from Home.
Useful? React with 👍 / 👎.
|


Summary
(home)layout/Stack