Repository navigation
fix: the profile census compiles again, and the decoder builds no_std - #20
Merged
Merged
Conversation
Two build breaks, both in profiling code, both blocking the campaign: - encoder (`--features profile`): the diamond and sub-pel loops lost the `enumerate()` that supplied `_si` (the rung index diastats::ev/imp count by) and `_pi` (the ring position spstats::ev/imp count by). Restored, with a comment saying which census reads each. release-plz runs cargo-semver-checks with every feature on, so this is what stopped the 0.16.x release. - decoder (no_std): the DQROUTE `report()` named `Vec`, which is not in the no_std prelude; it is `alloc::vec::Vec` now. Published 0.16.0 fails `cargo check --no-default-features --features libm` on riscv32imac/imafc, which is what rusty_esp_video's no_std jobs build. Checked: `cargo check -p rusty_h264-encoder --features profile --lib`, and `cargo check -p rusty_h264-decoder --no-default-features --features libm` on riscv32imac-unknown-none-elf and riscv32imafc-unknown-none-elf. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two build breaks, both in profiling code, both blocking the portfolio release campaign. 7 lines across two files.
Encoder,
--features profile. The diamond and sub-pel loops lost theenumerate()that supplied_si(the rung indexdiastats::ev/impcount by) and_pi(the ring positionspstats::ev/impcount by). This restores both, with a comment saying which census reads each. release-plz runscargo-semver-checkswith every feature on, so this is what has stopped the 0.16.x release.Decoder,
no_std. The DQROUTEreport()namedVec, which is not in the no_std prelude; it is nowalloc::vec::Vec. Published 0.16.0 failscargo check --no-default-features --features libmon riscv32imac/imafc, which is exactly what rusty_esp_video's no_std jobs build (rusty_esp_video#4 is red on it).Checked locally:
cargo check -p rusty_h264-encoder --features profile --libcargo check -p rusty_h264-decoder --no-default-features --features libmonriscv32imac-unknown-none-elfandriscv32imafc-unknown-none-elfNot touched:
mainis not rustfmt-clean (the long-standingclippy + fmtred), so this PR changes only these lines rather than mixing a 52-file reformat into a fix.🤖 Generated with Claude Code