Skip to content

Ab#133813 improve column sizing of custom actions#2870

Open
GhaziAlibi wants to merge 2 commits into
nextfrom
AB#133813-improve-column-sizing-of-custom-actions
Open

Ab#133813 improve column sizing of custom actions#2870
GhaziAlibi wants to merge 2 commits into
nextfrom
AB#133813-improve-column-sizing-of-custom-actions

Conversation

@GhaziAlibi

Copy link
Copy Markdown
Contributor

Description

This change resolves a layout issue where custom row action columns (e.g., the "Action" column containing action buttons) generated unnecessary whitespace. This occurred because the column width calculation was based statically on the sum of all configured action buttons, even if only one button was visible at any time per row.

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • check in the UI

Screenshots

Screencast_20260612_121437.webm

Checklist:

( * == Mandatory )

  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AntoineRelief

Copy link
Copy Markdown
Collaborator

hey @GhaziAlibi
Just a note about this PR, you put commits that are out of scope

It's fine for this PR I'll cherry pick the changes

@GhaziAlibi

Copy link
Copy Markdown
Contributor Author

weird, i did make sure i was on next with clean branch. I will make sure it will never happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants