Skip to content

Ab#133920 abc improve resource question#1239

Open
GhaziAlibi wants to merge 6 commits into
nextfrom
AB#133920-ABC-Improve-resource-question
Open

Ab#133920 abc improve resource question#1239
GhaziAlibi wants to merge 6 commits into
nextfrom
AB#133920-ABC-Improve-resource-question

Conversation

@GhaziAlibi

Copy link
Copy Markdown
Contributor

Description

This pull request improves the survey resource/resources questions and the back-office resource records view.

Useful links

Type of change

  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

  • Unit & Integration Tests: Executed npm run test on ems-backend (261 tests passed) and ems-frontend.
  • Manual UI Testing:
    • Verified resource dropdowns populate correctly and display selected records correctly during edition even if the record isn't on the first page of choices.
    • Verified back-office records grid displays all custom fields, works with pagination, correctly switches between active and archived views, and exports csv/xlsx with correct pagination payload.

Screenshots

form.webm
export.webm
res 1.webm

Checklist:

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant