Refactor the project layout#33
Closed
AR-DEV-1 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR restructures the project's build system by splitting the monolithic ChangesBuild System Modularization and Submodule Relocation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AR-DEV-1
force-pushed
the
project-layout-refactor
branch
from
a06a68f to
c8b1847
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmake/Shaders.cmake`:
- Around line 3-5: BGFX_INCLUDE currently points to a missing path; change it to
the actual location of BGFX shader headers (or add a fallback check) so shaderc
-i can find includes referenced from SHADER_SRC_DIR; specifically update the
BGFX_INCLUDE variable (in cmake/Shaders.cmake) to the real directory that
contains bgfx shader headers (e.g. the runtime thirdparty copy such as
"${CMAKE_SOURCE_DIR}/engine/runtime/thirdparty/bgfx/src" or
"${CMAKE_SOURCE_DIR}/engine/runtime/thirdparty/bgfx"), and add a CMake check
that verifies the directory exists and fails with a clear message if not,
leaving SHADER_SRC_DIR and SHADER_BIN_DIR unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 48fec280-4cf2-474e-83ed-e0317877ce60
⛔ Files ignored due to path filters (3)
engine/thirdparty/cmake/bgfx/generated/bounds.cpp.inis excluded by!**/generated/**engine/thirdparty/cmake/bgfx/generated/shader.cpp.inis excluded by!**/generated/**engine/thirdparty/cmake/bgfx/generated/vertexlayout.cpp.inis excluded by!**/generated/**
📒 Files selected for processing (146)
.gitmodulesCMakeLists.txtcmake/Modules.cmakecmake/Shaders.cmakeengine/CMakeLists.txtengine/core/CMakeLists.txtengine/core/core.cppmengine/core/definitions/definitions.cppmengine/core/definitions/stdtypes.cppmengine/core/definitions/version.cppmengine/core/io/filesystem.cppengine/core/io/filesystem.cppmengine/core/io/image_loader.cppengine/core/io/image_loader.cppmengine/core/io/io.cppmengine/core/math/constants.cppmengine/core/math/functions.cppmengine/core/math/math.cppmengine/core/math/math.test.cppengine/core/math/transform.cppengine/core/math/transform.cppmengine/core/math/types.cppmengine/core/math/types_common.cppmengine/core/math/vector2.cppmengine/core/math/vector3.cppmengine/core/math/vector4.cppmengine/core/memory/allocator.cppengine/core/memory/allocator.cppmengine/core/memory/bumpAllocator.cppengine/core/memory/bumpAllocator.cppmengine/core/memory/bumpAllocator.test.cppengine/core/memory/fixedAllocator.cppengine/core/memory/fixedAllocator.cppmengine/core/memory/fixedAllocator.test.cppengine/core/memory/handle.cppmengine/core/memory/handle_registry.cppmengine/core/memory/pageAllocator.cppengine/core/memory/pageAllocator.cppmengine/core/memory/root.cppmengine/core/memory/slice.cppmengine/core/memory/slot_array.cppmengine/core/memory/trackingAllocator.cppengine/core/memory/trackingAllocator.cppmengine/core/memory/trackingAllocator.test.cppengine/input/input.cppengine/input/input.cppmengine/native/CMakeLists.txtengine/native/thirdparty/bgfxengine/native/thirdparty/bimgengine/native/thirdparty/bxengine/native/thirdparty/sdlengine/platform/CMakeLists.txtengine/platform/cpu/cpu_info.hengine/platform/cpu/cpu_info_neon.cppengine/platform/cpu/cpu_info_x64.cppengine/platform/impl/CMakeLists.txtengine/platform/impl/linux/linux.cppengine/platform/impl/mac/mac.mmengine/platform/impl/platform_impl.hengine/platform/impl/win32/win32.cppengine/platform/platform.cppmengine/platform/simd.hengine/runtime/CMakeLists.txtengine/runtime/draconic.cppmengine/runtime/main/main.cppengine/runtime/rendering/CMakeLists.txtengine/runtime/rendering/material/material.cppmengine/runtime/rendering/mesh/mesh.cppengine/runtime/rendering/mesh/mesh.cppmengine/runtime/rendering/quad_renderer/quad_renderer.cppengine/runtime/rendering/quad_renderer/quad_renderer.cppmengine/runtime/rendering/renderer/renderer.cppengine/runtime/rendering/renderer/renderer.cppmengine/runtime/rendering/rendergraph/rendergraph.cppengine/runtime/rendering/rendergraph/rendergraph.cppmengine/runtime/rendering/rendering.cppmengine/runtime/rendering/rhi/buffers.cppengine/runtime/rendering/rhi/commands.cppengine/runtime/rendering/rhi/core.cppengine/runtime/rendering/rhi/macros.hengine/runtime/rendering/rhi/pipelines.cppengine/runtime/rendering/rhi/rhi.cppmengine/runtime/rendering/rhi/texture.cppengine/runtime/rendering/rhi/uniform_registry.cppmengine/runtime/rendering/rhi/vertex.cppmengine/runtime/rendering/shaders/fs.scengine/runtime/rendering/shaders/fs_quad.scengine/runtime/rendering/shaders/varying.def.scengine/runtime/rendering/shaders/varying_quad.def.scengine/runtime/rendering/shaders/vs.scengine/runtime/rendering/shaders/vs_quad.scengine/runtime/scene/CMakeLists.txtengine/runtime/scene/camera/camera_controller.cppengine/runtime/scene/camera/camera_controller.cppmengine/runtime/scene/renderable/renderable.cppmengine/runtime/scene/scene.cppmengine/runtime/scene/transform_component/transform_component.cppengine/runtime/scene/transform_component/transform_component.cppmengine/thirdparty/CMakeLists.txtengine/thirdparty/bgfxengine/thirdparty/bimgengine/thirdparty/bxengine/thirdparty/cmake/Config.cmake.inengine/thirdparty/cmake/bgfx/3rdparty/dear-imgui.cmakeengine/thirdparty/cmake/bgfx/3rdparty/fcpp.cmakeengine/thirdparty/cmake/bgfx/3rdparty/glsl-optimizer.cmakeengine/thirdparty/cmake/bgfx/3rdparty/glslang.cmakeengine/thirdparty/cmake/bgfx/3rdparty/meshoptimizer.cmakeengine/thirdparty/cmake/bgfx/3rdparty/spirv-cross.cmakeengine/thirdparty/cmake/bgfx/3rdparty/spirv-opt.cmakeengine/thirdparty/cmake/bgfx/3rdparty/tint.cmakeengine/thirdparty/cmake/bgfx/3rdparty/webgpu.cmakeengine/thirdparty/cmake/bgfx/CMakeLists.txtengine/thirdparty/cmake/bgfx/bgfx.cmakeengine/thirdparty/cmake/bgfx/examples.cmakeengine/thirdparty/cmake/bgfx/geometryc.cmakeengine/thirdparty/cmake/bgfx/geometryv.cmakeengine/thirdparty/cmake/bgfx/shaderc.cmakeengine/thirdparty/cmake/bgfx/shared.cmakeengine/thirdparty/cmake/bgfx/texturev.cmakeengine/thirdparty/cmake/bgfx/util/ConfigureDebugging.cmakeengine/thirdparty/cmake/bgfxToolUtils.cmakeengine/thirdparty/cmake/bimg/3rdparty/astc_encoder.cmakeengine/thirdparty/cmake/bimg/3rdparty/edtaa3.cmakeengine/thirdparty/cmake/bimg/3rdparty/etc1.cmakeengine/thirdparty/cmake/bimg/3rdparty/etc2.cmakeengine/thirdparty/cmake/bimg/3rdparty/iqa.cmakeengine/thirdparty/cmake/bimg/3rdparty/libsquish.cmakeengine/thirdparty/cmake/bimg/3rdparty/loadpng.cmakeengine/thirdparty/cmake/bimg/3rdparty/miniz.cmakeengine/thirdparty/cmake/bimg/3rdparty/nvtt.cmakeengine/thirdparty/cmake/bimg/3rdparty/pvrtc.cmakeengine/thirdparty/cmake/bimg/3rdparty/tinyexr.cmakeengine/thirdparty/cmake/bimg/CMakeLists.txtengine/thirdparty/cmake/bimg/bimg.cmakeengine/thirdparty/cmake/bimg/bimg_decode.cmakeengine/thirdparty/cmake/bimg/bimg_encode.cmakeengine/thirdparty/cmake/bimg/texturec.cmakeengine/thirdparty/cmake/bx/CMakeLists.txtengine/thirdparty/cmake/bx/bin2c.cmakeengine/thirdparty/cmake/bx/bx.cmakeengine/thirdparty/cmake/version.cmakeengine/thirdparty/doctest/doctest.hengine/thirdparty/sdlengine/thirdparty/stb/CMakeLists.txtengine/thirdparty/stb/stb_image.h
💤 Files with no reviewable changes (5)
- engine/native/thirdparty/sdl
- engine/native/thirdparty/bx
- engine/native/thirdparty/bgfx
- engine/native/thirdparty/bimg
- engine/native/CMakeLists.txt
Contributor
Author
|
@OldDev78 Will open a new PR with the refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
Refactor
Chores