Use a monospaced font for code blocks - #96
Open
edgar-bonet wants to merge 1 commit into
Open
Conversation
In new_style.css, line 7, the “html *” selector is overly greedy, and sets a proportional font on every element, overriding the more specific selector on line 183, which sets a monospaced font on code blocks. Use the simple “body” selector for setting the default document font, which allows for properly formatted code blocks. Fixes: a979f77 ("Added link to roboto")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
new_style.cssstylesheet sets the default document font with a CSS selector that is overly greedy. As a result, all text is displayed with a proportional font. This is fine for the main body text, but it is not suitable for code blocks, which should use a monospaced font instead.The proportional-font code blocks look particularly ugly on text output meant to be shaped as tabular data or as ANSI art.
This pull request sets a more standard and less greedy selector for the default font, which doesn't override every other font directive in the stylesheet. As a result, code blocks are properly formatted.