Skip to content

fix(dropdown): Add support for aria-disabled items to dropdowns #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshriver merged 1 commit into from
Jul 21, 2026
Merged

fix(dropdown): Add support for aria-disabled items to dropdowns #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/widgetastic_patternfly5/components/menus/dropdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,10 @@ def item_enabled(self, item, close=True, **kwargs):
# input element don't have such disabled attributes it at level of session.
is_el_enabled = el.is_enabled()
else:
is_el_enabled = "pf-m-disabled" not in self.browser.classes(el)
aria_disabled = str(self.browser.get_attribute("aria-disabled", el)).lower()
is_el_enabled = (
"pf-m-disabled" not in self.browser.classes(el) and aria_disabled != "true"
)
Comment thread
sourcery-ai[bot] marked this conversation as resolved.

if close:
self.close()
Expand Down
3 changes: 3 additions & 0 deletions testing/components/menus/test_dropdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def test_dropdown_items(dropdown):
assert not dropdown.has_item("Non existing items")
assert dropdown.item_enabled("Link")
assert not dropdown.item_enabled("Disabled Link")
assert not dropdown.item_enabled("Aria-disabled Link")


def test_dropdown_open(dropdown):
Expand All @@ -70,5 +71,7 @@ def test_dropdown_item_select(dropdown):
assert not dropdown.is_open
with pytest.raises(DropdownItemDisabled):
dropdown.item_select("Disabled Link")
with pytest.raises(DropdownItemDisabled):
dropdown.item_select("Aria-disabled Link")
with pytest.raises(DropdownItemNotFound):
dropdown.item_select("Non existing items")
Loading