Skip to content

Fix/pypi strict naming - #315

Merged
mshriver merged 2 commits into
RedHatQE:legacy-selenium-supportfrom
mshriver:fix/pypi-strict-naming
Jul 28, 2026
Merged

Fix/pypi strict naming#315
mshriver merged 2 commits into
RedHatQE:legacy-selenium-supportfrom
mshriver:fix/pypi-strict-naming

Conversation

@mshriver

@mshriver mshriver commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Build:

  • Remove explicit disabling of strict-naming for wheel and sdist Hatch build targets so distributions use strict naming defaults.

PyPI now enforces PEP 503/625 normalized filenames, so
strict-naming=false produces the rejected filename
'widgetastic.core-*.whl' instead of 'widgetastic_core-*.whl'.

Remove the strict-naming=false setting from both wheel and sdist
hatch build targets, matching the fix already on main (d1e5428).

Ref: RedHatQE#230
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude <noreply@anthropic.com>
@mshriver
mshriver changed the base branch from main to legacy-selenium-support July 28, 2026 17:36
@sourcery-ai

sourcery-ai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the explicit disabling of Hatch's strict-naming behavior for both wheel and sdist build targets, allowing Hatch to enforce standard package naming rules for the project.

Sequence diagram for enabling Hatch strict naming in build process

sequenceDiagram
    actor Developer
    participant Hatch
    participant WheelTarget
    participant SdistTarget

    Developer->>Hatch: hatch build
    Hatch->>WheelTarget: build_wheel_packages src_widgetastic [strict_naming]
    Hatch->>SdistTarget: build_sdist_packages src_widgetastic [strict_naming]
    WheelTarget-->>Hatch: wheel_artifact
    SdistTarget-->>Hatch: sdist_artifact
    Hatch-->>Developer: build_success_with_strict_naming
Loading

File-Level Changes

Change Details Files
Enable Hatch strict-naming behavior for all build targets by removing overrides that disabled it.
  • Removed the strict-naming = false override from the wheel build target configuration.
  • Removed the strict-naming = false override from the sdist build target configuration.
  • Left package paths and other build settings unchanged to rely on default Hatch behavior.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Co-authored-by: Claude <noreply@anthropic.com>
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.37500% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.25%. Comparing base (e3b6a13) to head (bb50625).
⚠️ Report is 1 commits behind head on legacy-selenium-support.

Files with missing lines Patch % Lines
src/widgetastic/utils.py 50.00% 7 Missing ⚠️
src/widgetastic/widget/table.py 75.00% 5 Missing ⚠️
src/widgetastic/browser.py 96.29% 1 Missing ⚠️
src/widgetastic/types.py 75.00% 1 Missing ⚠️
src/widgetastic/widget/base.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           legacy-selenium-support     #315      +/-   ##
===========================================================
- Coverage                    86.35%   86.25%   -0.10%     
===========================================================
  Files                           18       18              
  Lines                         2572     2481      -91     
===========================================================
- Hits                          2221     2140      -81     
+ Misses                         351      341      -10     
Flag Coverage Δ
unittests 86.25% <84.37%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mshriver
mshriver merged commit d337579 into RedHatQE:legacy-selenium-support Jul 28, 2026
12 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant