Skip to content

Pin wait_for for num_sec releted changes - #312

Merged
digitronik merged 3 commits into
RedHatQE:mainfrom
digitronik:pin_wait_for
Jul 13, 2026
Merged

Pin wait_for for num_sec releted changes#312
digitronik merged 3 commits into
RedHatQE:mainfrom
digitronik:pin_wait_for

Conversation

@digitronik

@digitronik digitronik commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Build:

  • Pin the wait-for dependency to version 2.0 or higher in project configuration.

Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the dependency specification for the wait-for library to pin a minimum version and aligns lockfile entries accordingly.

File-Level Changes

Change Details Files
Update the wait-for dependency to use the correct package name and enforce a minimum version.
  • Change dependency reference from wait_for to wait-for to match the published package name.
  • Add a >=2.0 version constraint to the wait-for dependency to pin behavior related to num_sec changes.
  • Regenerate or update the uv.lock file to reflect the new wait-for dependency specification.
pyproject.toml
uv.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.69%. Comparing base (89479c8) to head (507aed2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/widgetastic/browser.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   92.72%   92.69%   -0.04%     
==========================================
  Files          19       19              
  Lines        2750     2752       +2     
==========================================
+ Hits         2550     2551       +1     
- Misses        200      201       +1     
Flag Coverage Δ
unittests 92.69% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@digitronik
digitronik merged commit f4d4896 into RedHatQE:main Jul 13, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant