Skip to content

CherryPicked: [cnv-4.21] storage, tests, cdi_upload: Verify CDI upload in primary UDN namespace#5399

Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.21from
CherryPicked-add_volume_upload_to_pudn_scenario-HuVpS
Open

CherryPicked: [cnv-4.21] storage, tests, cdi_upload: Verify CDI upload in primary UDN namespace#5399
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.21from
CherryPicked-add_volume_upload_to_pudn_scenario-HuVpS

Conversation

@cnv-tests-github-webhook-dollierp

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp Bot commented Jun 25, 2026

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #5214, PR owner: Anatw

@Anatw
storage, tests, cdi_upload: Verify CDI upload in primary UDN namespace (
2f8dd66 
#5214)

##### What this PR does / why we need it:
Add a regression test that uploads a disk image to a DataVolume in a
PUDN namespace. This tests regression for bug CNV-58018 (CDI upload
proxy could not reach the uploader pod in namespaces with a primary
UDN).

##### Which issue(s) this PR fixes:

##### Special notes for reviewer:

##### jira-ticket:
NONE

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Tests**
* Added module-scoped pytest fixtures to provision an isolated Layer2
UDN environment for storage upload validation, including deterministic
subnet configuration and readiness checks.
* Added an end-to-end virtctl image upload test that creates a
DataVolume in the provisioned namespace, verifies the upload result, and
waits for the DataVolume to reach a successful state.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: ‪Anat Wax <awax@redhat.com>
Merged
@Anatw

Anatw commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

/build-and-push-container

@openshift-virtualization-qe-bot-5

openshift-virtualization-qe-bot-5 commented Jun 25, 2026

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message
  • /security-override - Set security check runs to pass (maintainers only)
  • /security-override cancel - Re-run security checks

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3
  • /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

  • /rebase - Rebase this PR branch onto its base branch

Custom Commands

  • /test-plan - Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • jpeimer

Reviewers:

  • Ahmad-Hafe
  • acinko-rh
  • dalia-frank
  • ema-aka-young
  • josemacassan
  • jpeimer
  • kgoldbla
  • kshvaika
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)
Security Checks
  • Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
  • Committer Identity Check: Verifies last committer matches PR author
  • Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@Anatw

Anatw commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

/retest all

@Anatw

Anatw commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/build-and-push-container

@openshift-virtualization-qe-bot

openshift-virtualization-qe-bot commented Jun 26, 2026

Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5399 published

@Anatw

Anatw commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

/verified

Tested on net-awax-421-n
Openshift version: 4.21.21
CNV version: 4.21.11
HCO image: brew.registry.redhat.io/rh-osbs/iib:1165106

openshift-virtualization-tests-runner/5803
PYTEST_PARAMS: -s -o log_cli=true -m tier2 --jira tests/storage/cdi_upload/test_upload_virtctl.py -k test_virtctl_image_upload_dv_in_pudn_namespace
==== 31 deselected, 1 xpassed, 18 warnings in 97.39s (0:01:37) ====

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anatw Anatw Awaiting requested review from Anatw
@ema-aka-young ema-aka-young Awaiting requested review from ema-aka-young
@jpeimer jpeimer Awaiting requested review from jpeimer
@acinko-rh acinko-rh Awaiting requested review from acinko-rh
@Ahmad-Hafe Ahmad-Hafe Awaiting requested review from Ahmad-Hafe
@josemacassan josemacassan Awaiting requested review from josemacassan
@kgoldbla kgoldbla Awaiting requested review from kgoldbla
@dalia-frank dalia-frank Awaiting requested review from dalia-frank
@kshvaika kshvaika Awaiting requested review from kshvaika

Assignees

@Anatw Anatw

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp[bot]

Labels

branch-cnv-4.21 CherryPicked-from-main sig-storage size/M tox:verify-tc-requirement-polarion:passed D/S Testing verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Anatw @openshift-virtualization-qe-bot-5 @openshift-virtualization-qe-bot @openshift-virtualization-qe-bot-4