WIP: net, multiarch: implement pod network connectivity tests

[servolkov]

What this PR does / why we need it:

Implement two ICMP connectivity tests between ARM64 and AMD64 VMs
over pod network. Each test creates VMs with explicit architecture
set on VMISpec, letting KubeVirt schedule them to the correct nodes.

Which issue(s) this PR fixes:

Special notes for reviewer:

The connectivity folder is too generic. Pod network multiarch tests
belong under primary_network/multiarch alongside other primary network
test subdirectories.

jira-ticket:

https://redhat.atlassian.net/browse/CNV-89416

Summary by CodeRabbit

• New Features
  • Added multi-architecture pod network connectivity coverage for IPv4 traffic between ARM and AMD virtual machines.
  • Introduced reusable ARM and AMD VM setup for multi-arch network testing.
• Tests
  • Added end-to-end connectivity checks in both directions to validate pod-to-pod reachability across architectures.
  • Removed an obsolete connectivity test module from the suite.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes an obsolete disabled multi-arch pod-network test module and adds ARM64/AMD64 VM fixtures plus new IPv4 ping tests that verify pod-network reachability in both directions.

Changes

Multiarch pod-network reachability

Layer / File(s)	Summary
VM fixtures by architecture tests/network/primary_network/multiarch/conftest.py	Imports architecture helpers and defines arm_vm and amd_vm fixtures that build Fedora VMs for ARM_64 and AMD_64, start them, wait for agent connectivity, and yield the running VMs.
Bidirectional ping tests tests/network/primary_network/multiarch/test_pod_network.py	Adds TestMultiArchPodNetwork with ARM→AMD and AMD→ARM IPv4 ping checks over the pod network, tagged with multiarch, single_nic, and ipv4; this replaces the old disabled module.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• RedHatQE/openshift-virtualization-tests#4810: Shares the VM architecture wiring needed by the new ARM64/AMD64 fixtures and multiarch connectivity tests.

Suggested labels

new-tests

Suggested reviewers

• yossisegev
• Anatw
• orelmisan
• EdDev
• nirdothan

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Stp Link Required	❌ Error	New test file lacks the required exact traceability label; its module docstring says 'STP Reference:' instead of 'STP:'.	Change the new test module/class docstring to include an exact 'STP: ' line, or add a Jira/RFE line with the required skip marker.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	All required sections are present, and the only gap is an empty issue list, which is non-critical because a Jira ticket is provided.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise, under 120 characters, and clearly describes the new multiarch pod network connectivity tests.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped RedHatQE/openshift-virtualization-tests-design-docs.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[servolkov]

/wip

[openshift-virtualization-qe-bot]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message
• /security-override - Set security check runs to pass (maintainers only)
• /security-override cancel - Re-run security checks

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3
• /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

• /rebase - Rebase this PR branch onto its base branch

Custom Commands

• /test-plan - Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• EdDev
• rnetser

Reviewers:

• Anatw
• EdDev
• azhivovk
• frenzyfriday
• nirdothan
• orelmisan
• rnetser
• servolkov
• yossisegev

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)

Security Checks

• Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
• Committer Identity Check: Verifies last committer matches PR author
• Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/network/primary_network/multiarch/test_pod_network.py`:
- Around line 38-40: The ping-based connectivity checks in
test_pod_network_connectivity_arm_to_amd and
test_pod_network_connectivity_amd_to_arm only execute arm_vm.console(...) and
never assert that the ping output shows 0% packet loss. Update the tests to
explicitly validate the ping result after build_ping_command, either by parsing
the console output for the expected packet-loss string or by using an existing
connectivity/assertion helper if one already exists, so partial loss does not
pass silently.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 87a6c1cf-9fe3-4376-a641-b19a3619453f

📥 Commits

Reviewing files that changed from the base of the PR and between d5e5c3d and c69d6e0.

📒 Files selected for processing (4)

• tests/network/connectivity/test_pod_network_multiarch.py
• tests/network/primary_network/multiarch/__init__.py
• tests/network/primary_network/multiarch/conftest.py
• tests/network/primary_network/multiarch/test_pod_network.py

💤 Files with no reviewable changes (1)

• tests/network/connectivity/test_pod_network_multiarch.py