Skip to content

[STORGE][GATING] Add retry for virtctl download to handle transient SSL errors #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ahmad-Hafe wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −4
Open

[STORGE][GATING] Add retry for virtctl download to handle transient SSL errors #5355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2082968
Add retry for virtctl download to handle transient SSL errors
Ahmad-Hafe Jun 23, 2026
4e8b819
Wrap entire download operation in retried callable with context manager
Ahmad-Hafe Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions utilities/infra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,10 +690,25 @@ def download_and_extract_file_from_cluster(tmpdir, url):
LOGGER.info(f"Downloading archive using: url={url}")
urllib3.disable_warnings() # TODO: remove this when we fix the SSL warning
local_file_name = os.path.join(tmpdir, url.split("/")[-1])
with requests.get(url, verify=False, stream=True) as created_request:
created_request.raise_for_status()
with open(local_file_name, "wb") as file_downloaded:
file_downloaded.writelines(created_request.iter_content(chunk_size=8192))
for sample in TimeoutSampler(
wait_timeout=TIMEOUT_2MIN,
sleep=TIMEOUT_10SEC,
func=requests.get,
exceptions_dict={
requests.exceptions.SSLError: [],
requests.exceptions.ConnectionError: [],
requests.exceptions.Timeout: [],
},
url=url,
verify=False,
stream=True,
timeout=TIMEOUT_30SEC,
):
with sample:
sample.raise_for_status()
with open(local_file_name, "wb") as file_downloaded:
file_downloaded.writelines(sample.iter_content(chunk_size=8192))
break
LOGGER.info("Extract the downloaded archive.")
if url.endswith(zip_file_extension):
archive_file_object = zipfile.ZipFile(file=local_file_name)
Expand Down