Skip to content

[Storage] STD: Make Velero Hooks in virt-launcher Optional or Removable #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ema-aka-young wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Storage] STD: Make Velero Hooks in virt-launcher Optional or Removable #5340

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
88cf218
STD: init
ema-aka-young Jun 9, 2026
c60a158
Merge branch 'main' into CNV-88654-velero-hooks-std
ema-aka-young Jun 15, 2026
25d3ea3
STD for velero_backup_hooks
ema-aka-young Jun 16, 2026
9b40378
Removed log-parsing verification
ema-aka-young Jun 16, 2026
4ce502c
Refine expected outcomes for paused VM backup test in Velero hooks
ema-aka-young Jun 16, 2026
1d02145
Merge remote-tracking branch 'upstream/main' into CNV-88654-velero-ho…
ema-aka-young Jun 23, 2026
68dd34d
Use quality-flow input STD
ema-aka-young Jun 23, 2026
d586d82
"STP Reference" -> "STP"
ema-aka-young Jun 23, 2026
c74b13b
QualityFlow: 2nd iteration
ema-aka-young Jun 24, 2026
9953da0
Add numbered step format
ema-aka-young Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions tests/data_protection/oadp/test_velero_backup_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
"""
Comment thread
ema-aka-young marked this conversation as resolved.
Comment thread
ema-aka-young marked this conversation as resolved.
Velero Backup Hook Opt-Out Tests

STP: https://github.com/RedHatQE/openshift-virtualization-tests-design-docs/blob/main/stps/sig-storage/remove-velero-hooks-stp.md
Jira: https://redhat.atlassian.net/browse/CNV-79727 # <skip-jira-utils-check>
"""

import pytest


class TestVeleroBackupHookOptOut:
"""
Tests for Velero backup hook opt-out with backup/restore operations.

Preconditions:
- VM with backup hooks disabled
"""

__test__ = False

@pytest.mark.polarion("CNV-16267")
def test_backup_paused_vm_hooks_disabled(self):

@dalia-frank dalia-frank Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both of these tests? I'm not sure I fully understand the difference between them, aside from the restore part in the second test. Could you clarify the intent?

@ema-aka-young ema-aka-young Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main difference is the VM state. In this one we are performing the backup of a paused VM to provide coverage for this use case.

@dalia-frank dalia-frank Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to restore the VM?

@ema-aka-young ema-aka-young Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the STP:

  • [CNV-79727] — As a cluster administrator, I want to verify that the opt-out annotation is honored for a paused VM, confirming hooks are not injected regardless of VM state
    • Test Scenario: [Tier 2] Deploy a VM configured to opt out of backup hooks and pause it. Run a Velero backup. Confirm no hooks were attempted and the backup completed successfully.

This case proves the annotation is honored for a paused state, while the next one proves the full backup/restore works without hooks. From my understanding, the restore doesn't know or care if the state of VM when backing up was paused or running.

"""
Test that backup of paused VM completes with hooks disabled.

Preconditions:
- VM with backup hooks disabled, paused

Steps:
1. Run Velero backup

Expected:
Backup completes successfully without freeze/unfreeze hook execution
"""

@pytest.mark.polarion("CNV-16268")
def test_full_backup_restore_hooks_disabled(self):
"""
Test that full backup/restore cycle completes with hooks disabled.

Preconditions:
- Running VM with backup hooks disabled

Steps:
1. Run Velero backup
2. Delete VM and namespace
3. Restore from backup

Expected:
VM is restored and running after backup/restore cycle
"""