refactor(constants): migrate tests/network/ to direct submodule imports#5321
refactor(constants): migrate tests/network/ to direct submodule imports#5321vsibirsk wants to merge 1 commit into
Conversation
|
Warning Review limit reached
More reviews will be available in 27 minutes and 12 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (37)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-6
requested review from
RoniKishner,
azhivovk,
dshchedr,
nirdothan,
orelmisan,
rlobillo,
rnetser,
servolkov and
yossisegev
Replace all `from utilities.constants import X` in tests/network/ (38 files) with direct submodule imports. No logic changes. Generated-by: Claude Sonnet 4.6 Signed-off-by: vsibirsk <vsibirsk@redhat.com>
vsibirsk
force-pushed
the
vk-migrate-network-imports
branch
from
d857708 to
0ad7a5b
Compare
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:passed
|
/verified collect only since it's only import path updates (no logic change) |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| import pytest | ||
|
|
||
| from utilities.constants import TIMEOUT_9MIN | ||
| from utilities.constants.timeouts import TIMEOUT_9MIN |
There was a problem hiding this comment.
Test Execution Plan
This PR only refactors import paths in tests/network/ (38 files): from utilities.constants import X → from utilities.constants.<submodule> import X. No logic, fixture, or utility symbol changes.
- Run smoke tests: False — No modified utility/lib symbols; no traceable dependency path from any smoke-marked test to a changed symbol.
- Run gating tests: False — No modified utility/lib symbols; no traceable dependency path from any gating-marked test to a changed symbol.
Affected tests to run
Collection verification is sufficient (already confirmed by /verified):
pytest tests/network/ --collect-only
Expected: all 201 tests collected (matching the pre-merge baseline).
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get the list of changed files and first changed line
gh pr view 5321 --repo RedHatQE/openshift-virtualization-tests --json files --jq '.files[0]'
# Get diff to find first changed line number
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5321/files --jq '.[0] | {filename: .filename, patch: .patch}' | head -40Length of output: 952 🏁 Script executed: #!/bin/bash
# Get PR head SHA
PR_DATA=$(gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5321 --jq '{sha: .head.sha}')
echo "$PR_DATA"
HEAD_SHA=$(echo "$PR_DATA" | jq -r '.sha')
# Post inline review comment on the first changed line (position 5 in diff = line 11 RIGHT side)
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5321/reviews \
--method POST \
--field commit_id="$HEAD_SHA" \
--field body="" \
--field event="COMMENT" \
--field "comments[][path]=tests/network/bond/test_bond_modes.py" \
--field "comments[][line]=11" \
--field "comments[][side]=RIGHT" \
--field "comments[][body]=**Test Execution Plan**
This PR only refactors import paths in \`tests/network/\` (38 files): \`from utilities.constants import X\` → \`from utilities.constants.<submodule> import X\`. No logic, fixture, or utility symbol changes.
- **Run smoke tests: False** — No modified utility/lib symbols; no traceable dependency path from any smoke-marked test to a changed symbol.
- **Run gating tests: False** — No modified utility/lib symbols; no traceable dependency path from any gating-marked test to a changed symbol.
**Affected tests to run**
Collection verification is sufficient (already confirmed by \`/verified\`):
\`\`\`
pytest tests/network/ --collect-only
\`\`\`
Expected: all 201 tests collected (matching the pre-merge baseline)."Length of output: 3300 |
7 participants
What this PR does / why we need it:
Replace all
from utilities.constants import Xin tests/network/ (38 files) with direct submodule imports. No logic changes.Generated-by: Claude Sonnet 4.6
Which issue(s) this PR fixes:
Special notes for reviewer:
This is a next PR in a series.
https://redhat.atlassian.net/browse/CNV-80952 and a follow up of #5188
jira-ticket:
https://redhat.atlassian.net/browse/CNV-89566