Remove CNV-86102 xfail workaround for virt-platform-autopilot priority class#5309
Conversation
…y class CNV-86102 is resolved (ON_QA) — virt-platform-autopilot now has a priority class set. Remove the xfail guards so tests validate the fix. Signed-off-by: Ramón Lobillo <rlobillo@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughRemoves the ChangesRemove CNV-86102 Jira xfail wiring
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-5
requested review from
OhadRevah,
RoniKishner,
albarker-rh,
dshchedr and
hmeir
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
generate_test_report |
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5309 published |
|
Verification failed for PR #5309. Execution details |
|
/verified |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check for smoke markers in affected test files
rg -n '`@pytest.mark.smoke`' tests/install_upgrade_operators/deployment/test_hco_deployment_params.py tests/install_upgrade_operators/pod_validation/test_pod_spec.py tests/install_upgrade_operators/conftest.py 2>/dev/null || echo "No smoke markers found in affected files"
# Check for gating markers in affected test files
rg -n '`@pytest.mark.gating`' tests/install_upgrade_operators/deployment/test_hco_deployment_params.py tests/install_upgrade_operators/pod_validation/test_pod_spec.py tests/install_upgrade_operators/conftest.py 2>/dev/null || echo "No gating markers found in affected files"
# Check for smoke markers broadly in install_upgrade_operators
rg -l '`@pytest.mark.smoke`' tests/install_upgrade_operators/ 2>/dev/null || echo "No smoke markers in install_upgrade_operators"
# Check for gating markers broadly
rg -l '`@pytest.mark.gating`' tests/install_upgrade_operators/ 2>/dev/null || echo "No gating markers in install_upgrade_operators"
# Get the PR diff to understand first changed line
gh pr diff 5309 --repo RedHatQE/openshift-virtualization-tests | head -80Length of output: 5066 🏁 Script executed: #!/bin/bash
# Get the latest commit SHA for the PR
COMMIT_SHA=$(gh pr view 5309 --repo RedHatQE/openshift-virtualization-tests --json headRefOid --jq '.headRefOid')
echo "Commit SHA: $COMMIT_SHA"
# Post inline review comment on the first changed line of conftest.py (line 284 - deletion of jira_86102_open fixture)
gh api \
--method POST \
-H "Accept: application/vnd.github+json" \
repos/RedHatQE/openshift-virtualization-tests/pulls/5309/reviews \
--field commit_id="$COMMIT_SHA" \
--field event="COMMENT" \
--field body="" \
--field 'comments[][path]=tests/install_upgrade_operators/conftest.py' \
--field 'comments[][line]=283' \
--field 'comments[][side]=RIGHT' \
--field 'comments[][body]=**Test Execution Plan**
**Run smoke tests: False** — No smoke markers found in any of the modified files; no traced dependency path from modified symbols to smoke-marked tests.
**Run gating tests: True** — `test_cnv_deployment_priority_class_name` is decorated with `@pytest.mark.gating` (line 67 in `test_hco_deployment_params.py`) and is directly modified by this PR (removal of `jira_86102_open` parameter and the associated xfail branch).
**Affected tests to run:**
- `tests/install_upgrade_operators/deployment/test_hco_deployment_params.py::test_cnv_deployment_priority_class_name` (gating) — xfail guard for `virt-platform-autopilot` removed; test will now actively validate its `priorityClassName`.
- `tests/install_upgrade_operators/pod_validation/test_pod_spec.py::test_pods_priority_class_value` — xfail guard for `virt-platform-autopilot` pods removed; test will now validate priority class value for these pods.'Length of output: 3483 |
|
/verified cancel |
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5309 published |
|
/verified All tests passed for PR #5309. Execution details |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get commit SHA
COMMIT_SHA=$(gh pr view 5309 --repo RedHatQE/openshift-virtualization-tests --json headRefOid --jq '.headRefOid')
echo "Commit SHA: $COMMIT_SHA"
# Get the diff to find first changed line of first file
gh pr diff 5309 --repo RedHatQE/openshift-virtualization-tests | head -100
# Check for smoke and gating markers in affected files
rg -n '`@pytest.mark.smoke`' tests/install_upgrade_operators/deployment/test_hco_deployment_params.py tests/install_upgrade_operators/pod_validation/test_pod_spec.py tests/install_upgrade_operators/conftest.py 2>/dev/null || echo "No smoke markers"
rg -n '`@pytest.mark.gating`' tests/install_upgrade_operators/deployment/test_hco_deployment_params.py tests/install_upgrade_operators/pod_validation/test_pod_spec.py tests/install_upgrade_operators/conftest.py 2>/dev/null || echo "No gating markers"Length of output: 4522 🏁 Script executed: #!/bin/bash
COMMIT_SHA="9740cf5bfa42a275dccff6a02a1dd4615821352c"
gh api \
--method POST \
-H "Accept: application/vnd.github+json" \
repos/RedHatQE/openshift-virtualization-tests/pulls/5309/reviews \
--field commit_id="$COMMIT_SHA" \
--field event="COMMENT" \
--field body="" \
--field 'comments[][path]=tests/install_upgrade_operators/conftest.py' \
--field 'comments[][line]=284' \
--field 'comments[][side]=LEFT' \
--field 'comments[][body]=**Test Execution Plan**
**Run smoke tests: False** — No `@pytest.mark.smoke` markers found in any modified file; no traced dependency path from modified symbols to smoke-marked tests.
**Run gating tests: True** — `test_cnv_deployment_priority_class_name` (line 67, `tests/install_upgrade_operators/deployment/test_hco_deployment_params.py`) carries `@pytest.mark.gating` and is directly modified by this PR (removal of `jira_86102_open` parameter and the `VIRT_PLATFORM_AUTOPILOT` xfail branch).
**Affected tests to run:**
- `tests/install_upgrade_operators/deployment/test_hco_deployment_params.py::test_cnv_deployment_priority_class_name` *(gating)* — xfail guard for `virt-platform-autopilot` removed; test now actively validates `priorityClassName` is set for this deployment.
- `tests/install_upgrade_operators/pod_validation/test_pod_spec.py::test_pods_priority_class_value` — xfail guard for `virt-platform-autopilot` pods removed; test now validates priority class value for these pods.'Length of output: 3250 |
|
/approve |
|
/cherry-pick cnv-4.22 |
|
Cherry-pick conflicts were resolved by AI Cherry-picked PR Remove CNV-86102 xfail workaround for virt-platform-autopilot priority class into cnv-4.22: #5393 @rlobillo Manual verification is required — please review the changes and test before merging. |
10 participants
What this PR does / why we need it:
CNV-86102 reported that
virt-platform-autopilotdeployment didn't have a priority class set. The bug is now resolved (ON_QA), so we remove thexfailworkarounds that were skipping priority class validation for this component.Changes:
jira_86102_opensession fixture fromtests/install_upgrade_operators/conftest.pyvirt-platform-autopilotintest_cnv_deployment_priority_class_namevirt-platform-autopilotintest_pods_priority_class_valueVIRT_PLATFORM_AUTOPILOTimportsTests will now properly validate that
virt-platform-autopilothas a priority class set.Which issue(s) this PR fixes:
CNV-86102
Special notes for reviewer:
jira-ticket:
CNV-86102
Summary by CodeRabbit