Repository navigation
Conversation
…lers (ReamLabs#1579) Corrects multiple non-spec routes and missing handler registrations in crates/rpc/beacon: - Correct blinded blocks GET route from /beacon/blind_block/{block_id} to /beacon/blinded_blocks/{block_id} and rename handler to get_blinded_block per Ethereum Beacon API spec. - Fix route path typo /beacon/pool/prposer_slashings to /beacon/pool/proposer_slashings and method typo get_all_proposer_slahsings to get_all_proposer_slashings in OperationPool (retaining deprecated alias for backwards compatibility). - Register post_sync_committee_selections in register_validator_routes_v1 and update payload parameter to Json<Vec<SyncCommitteeSelection>> to match spec. - Add unit and integration tests covering spec routes and handler status codes. Closes ReamLabs#1579
alok-108
requested review from
Kayden-ML,
KolbyML and
shariqnaiyer
as code owners
October 5, 2026 23:38
Author
|
Hey @KolbyML @Kayden-ML @shariqnaiyer, opened a fix for #1579 (route typos and the missing sync committee handler). Whenever you get a chance, could you approve the CI run? Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Several non-spec route paths and missing handler registrations in
crates/rpc/beacon/prevented standard Ethereum Beacon API compliance, resulting in404 Not Founderrors when clients (validator clients, builder relays, slashers) made standard requests:GET /eth/v1/beacon/blind_block/{block_id}was exposed instead of the spec-mandatedGET /eth/v1/beacon/blinded_blocks/{block_id}(Ethereum Beacon API - getBlindedBlock).#[get("/beacon/pool/prposer_slashings")](missingo), causingGET /eth/v1/beacon/pool/proposer_slashingsto 404. Furthermore,OperationPool::get_all_proposer_slahsingscontained a typo.POST /eth/v1/validator/sync_committee_selectionshandler was implemented inhandlers/validator.rsbut never registered inregister_validator_routes_v1. In addition, the spec defines the request body as an arrayVec<SyncCommitteeSelection>, whereas the handler accepted a single objectSyncCommitteeSelection.Closes #1579
How was it fixed?
#[get("/beacon/blind_block/{block_id}")]to#[get("/beacon/blinded_blocks/{block_id}")].get_blinded_blockand updated its registration inroutes/beacon.rs.#[get("/beacon/pool/proposer_slashings")]and updated doc comment to v1.OperationPool::get_all_proposer_slahsingstoget_all_proposer_slashingswhile retaining a#[deprecated]alias for backwards compatibility.crates/rpc/beacon/src/handlers/pool.rsandcrates/rpc/beacon/src/handlers/validator.rs.post_sync_committee_selectionsonregister_validator_routes_v1.Json<Vec<SyncCommitteeSelection>>to adhere to the spec schema.ream-operation-pooltestingget_all_proposer_slashings.crates/rpc/beacon/src/tests.rsverifying that:GET /eth/v1/beacon/pool/proposer_slashingsreturns200 OK(and old/prposer_slashingsreturns 404).POST /eth/v1/validator/sync_committee_selectionsreturns501 Not Implementedwith vector payload (verifying registration instead of 404).GET /eth/v1/beacon/blinded_blocks/{block_id}is routed properly.cargo +nightly fmt --check.cargo clippy --features devnet5 -p ream-rpc-beacon -p ream-operation-pool.To-Do