Repository navigation
fix(lean): refuse proposals outside prepared key interval - #1591
Open
groverInnovate wants to merge 1 commit into
Open
groverInnovate wants to merge 1 commit into
groverInnovate wants to merge 1 commit into
Conversation
Contributor
Author
|
@KolbyML can you review this PR and check whether this guard and error behaviour look appropriate? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
An active proposal slot outside the key’s prepared window reaches leanSig’s assertion, panicking an RPC worker or the production block-building task. The registered signer sequences in Hive #1619 exposed this missing integration check.
How was it fixed?
Check the prepared interval before signing and return
slot_outside_prepared_interval. Existing RPC handling turns this into a structured refusal, and production block building follows its normal error path. Two regressions cover refusal with verified recovery and production-task containment, using existing public key fixtures.This contains the failure; it does not implement preparation advancement or change attestation signing.
Validation: 6 validator tests and 2 RPC tests pass; workspace formatting, Cargo sorting, and both CI Clippy configurations pass. Both registered Docker Hive sequences pass with the fixed binary in the standard Ream runtime: 5 signatures independently verified and 20 negative controls rejected.