added endpoint for generating and getting discord invite for user - #1553
Merged
Conversation
vinayak-trivedi
marked this pull request as draft
September 24, 2023 05:33
…ackend into discord-invite-api
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| router.post("/groups", authenticate, checkIsVerifiedDiscord, validateGroupRoleBody, createGroupRole); | ||
| router.get("/groups", authenticate, checkIsVerifiedDiscord, getAllGroupRoles); | ||
| router.post("/roles", authenticate, checkIsVerifiedDiscord, validateMemberRoleBody, addGroupRoleToMember); | ||
| router.get("/invite", authenticate, getUserDiscordInvite); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| router.get("/groups", authenticate, checkIsVerifiedDiscord, getAllGroupRoles); | ||
| router.post("/roles", authenticate, checkIsVerifiedDiscord, validateMemberRoleBody, addGroupRoleToMember); | ||
| router.get("/invite", authenticate, getUserDiscordInvite); | ||
| router.post("/invite", authenticate, checkCanGenerateDiscordLink, generateInviteForUser); |
Check failure
Code scanning / CodeQL
Missing rate limiting
vinayak-trivedi
marked this pull request as ready for review
October 27, 2023 16:18
vinayak-trivedi
changed the title
Member
|
Tests are failing |
satyam73
suggested changes
Oct 28, 2023
satyam73
left a comment
satyam73
left a comment
Contributor
There was a problem hiding this comment.
Please also write validators for the request data
Contributor
|
Tests are failing, please have a look |
heyrandhirs
suggested changes
Oct 28, 2023
Contributor
|
Generally Tejas recommends to follow the standard template like |
satyam73
reviewed
Oct 28, 2023
Contributor
|
Test are failing please have a look |
satyam73
reviewed
Oct 30, 2023
vinayak-trivedi
changed the title
heyrandhirs
previously approved these changes
Nov 2, 2023
satyam73
reviewed
Nov 2, 2023
Co-authored-by: Satyam Bajpai <bajpai1973satyam@gmail.com>
heyrandhirs
previously approved these changes
Nov 2, 2023
vinayak-trivedi
dismissed stale reviews from heyrandhirs and satyam73
via
November 9, 2023 15:28
c8e52fb
satyam73
previously approved these changes
Nov 9, 2023
heyrandhirs
previously approved these changes
Nov 10, 2023
prakashchoudhary07
requested changes
Nov 17, 2023
vinayak-trivedi
dismissed stale reviews from heyrandhirs and satyam73
via
November 18, 2023 15:36
9f2870c
prakashchoudhary07
approved these changes
Nov 29, 2023
vinit717
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1631
Backend changes
Frontend Changes
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Tested in staging
Controllers file
checkCanGenerateDiscordLink middleware
model file
**Api contract: **https://github.com/Real-Dev-Squad/website-api-contracts/pull/157/files?short_path=081a121#diff-081a121ca09a9dacb560d4ae94cada3b27a681f8cde30c68b5f307abb87930da
**Data model docs: ** RealDevSquad/website-data-models#60