Skip to content

Prioritize group storage #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReagentX merged 3 commits into from
Sep 16, 2026
Merged

Prioritize group storage #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8f969e
Replace inner vectors with `One(OutputData) | Many(Vec<OutputData>)`
ReagentX Sep 16, 2026
e9b6d84
Fix stream desync for embedded structures like `encodeValuesOfObjCTyp…
ReagentX Sep 16, 2026
0982983
Refactor DataGroup and ObjectData to reduce indirection
ReagentX Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/deserializer/iter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use core::slice::Iter;
use alloc::vec::Vec;

use crate::models::{
archived::{Archived, ObjectData},
archived::{Archived, DataGroup, ObjectData},
class::Class,
output_data::OutputData,
types::{Type, TypeEntry},
Expand Down Expand Up @@ -220,8 +220,8 @@ pub struct PropertyIterator<'a, 'b> {
enum GroupSource<'a, 'b> {
/// A single inline value that forms one group; yielded exactly once.
Inline(Option<&'b OutputData<'a>>),
/// An iterator over the object's group vectors.
Groups(Iter<'b, Vec<OutputData<'a>>>),
/// An iterator over the object's data groups.
Groups(Iter<'b, DataGroup<'a>>),
}

impl<'a, 'b> PropertyIterator<'a, 'b> {
Expand Down
Loading
Loading