Feat/cs/refactor shutdown#133
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the shutdown process and modifies how streams are managed during application exit. Key changes include:
- Replacing Mutex with AtomicBool for shutdown signaling and adjusting thread handling in shutdown.
- Storing thread handles and child process references in InputStream and updating error handling.
- Improving startup error recovery to prevent unassigned stream handles.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/util/error.rs | Updated error message for invalid commands. |
| src/communication/reader.rs | Changed shutdown logic to use AtomicBool, join threads, and update shutdown procedure. |
| src/communication/input.rs | Refactored CommandInput to use AtomicBool and store thread handles and child processes. |
| src/communication/handlers/startup.rs | Enhanced error handling by matching on build_streams_from_input result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AtomicBoolinstead ofMutex<bool>InputStream