fix: encode referer header to fix #1206#1268
Conversation
|
Could you provide some example cases for this? |
|
Hi, You are right that standard domain name shouldn't contain non-ASCII characters. However, the When these non-ASCII strings are passed directly into OkHttp's headers, OkHttp strictly validates them and throws a fatal Here is a real-world example case. If we subscribe to To be honest, my previous PR didn't work properly as I'm not very familiar with Android or Kotlin development, and I don't have a complete local environment on this machine to fully test it. I'm not quite sure how to implement the most idiomatic fix for ReadYou, but my basic idea is to use Since there is definitely a crash bug here, I would be very grateful if you could take over and implement a proper fix, or give me some guidance/suggestions on how to write it correctly. Thanks for your time : ) |
Encode referer header to avoid crashing when header includes non-ASCII characters.