fix(takeLast): prevent RangeError when count is Infinity#7608
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
`takeLast(Infinity)` threw `RangeError: Invalid array length` because `new Array(Infinity)` is not a valid JavaScript expression. Fix by conditionally allocating the ring buffer only when count is finite. For non-finite counts the operator falls back to a growable array. The ring-buffer index arithmetic already handles this correctly since `n % Infinity === n` for all finite n, so no further changes are needed. Fixes: https://github.com/ReactiveX/rxjs/issues/XXXX
Contributor
|
IMO On the other hand that would change the existing behavior of only emitting the items on complete to emitting immediately... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
takeLast(Infinity)throws aRangeError: Invalid array lengthat subscription time:The cause is line 50 of
takeLast.ts:JavaScript forbids creating an array with a non-integer or infinite length argument.
Fix
Use a growable array (
[]) whencountis non-finite. The ring-buffer index arithmetic already handlesInfinitycorrectly becausen % Infinity === nfor every finiten, so no further changes to the logic are required:After the fix,
takeLast(Infinity)behaves liketakeLast(n)wheren >= source.length: it buffers every value and emits them all on completion.Tests
Two new tests added to
takeLast-spec.ts: