Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-dragons-start.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'fx-media-controller': patch
---

Fixed MediaController.pause() require an argument for FF v154.0
4 changes: 4 additions & 0 deletions .github/workflows/changesets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v7
with:
token: ${{ secrets.RELEASE_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v7
Expand All @@ -88,3 +90,5 @@ jobs:

- name: Publish packages
uses: changesets/action/publish@v2
with:
github-token: ${{ secrets.RELEASE_TOKEN }}
2 changes: 1 addition & 1 deletion src/media/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export function toggleMediaController(tab: BrowserTab): void {
const controller = getActiveController(tab);
if (!controller) return;
if (controller.isPlaying) {
controller.pause();
controller.pause('user');
} else {
controller.play();
}
Expand Down
10 changes: 9 additions & 1 deletion types/gecko-media.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ interface PositionStateEvent extends Event {

interface AudioSessionType {}

/**
* The reason a chrome caller is pausing the controller. "user" preserves the
* existing user-initiated pause; the "system-*" values represent an
* audio-focus loss, with "system-transient" being resumable and
* "system-permanent" not.
*/
type AudioFocusLossReason = 'user' | 'system-transient' | 'system-permanent';

interface MediaController extends EventTarget {
readonly id: number;
readonly isActive: boolean;
Expand All @@ -54,7 +62,7 @@ interface MediaController extends EventTarget {

focus(): void;
play(): void;
pause(): void;
pause(reason: AudioFocusLossReason): void;
resume(): void;
stop(): void;
mute(): void;
Expand Down
Loading