Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"@angular/animations": "^14.0.0",
"@angular/common": "^14.0.0",
"@angular/compiler": "^14.0.0",
"@angular/compiler": "^19.2.17",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR introduces a version mismatch between Angular packages. @angular/compiler is upgraded to ^19.2.17, while other @angular packages like @angular/core remain on ^14.0.0. All @angular/* packages within a project should use the same version to ensure compatibility and prevent build/runtime errors. A major version jump from 14 to 19 will almost certainly break the application.

It is recommended to either upgrade all @angular/* packages to the same major version (e.g., ~19.2.17) or find a security patch for @angular/compiler that is compatible with version 14. Since this PR only upgrades a single package, it's best to revert this change and perform a full Angular upgrade in a separate, manual PR.

Suggested change
"@angular/compiler": "^19.2.17",
"@angular/compiler": "^14.0.0",

@cubic-dev-ai cubic-dev-ai Bot Dec 8, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: Major version mismatch: @angular/compiler@^19.2.17 is incompatible with all other Angular packages at ^14.0.0. Angular packages must be kept at the same major version due to strict peer dependencies. This upgrade will cause build failures and runtime errors. To fix the XSS vulnerability, all Angular packages should be upgraded together to version 19, or an alternative patch for v14 should be sought.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 18:

<comment>Major version mismatch: `@angular/compiler@^19.2.17` is incompatible with all other Angular packages at `^14.0.0`. Angular packages must be kept at the same major version due to strict peer dependencies. This upgrade will cause build failures and runtime errors. To fix the XSS vulnerability, all Angular packages should be upgraded together to version 19, or an alternative patch for v14 should be sought.</comment>

<file context>
@@ -15,7 +15,7 @@
     &quot;@angular/animations&quot;: &quot;^14.0.0&quot;,
     &quot;@angular/common&quot;: &quot;^14.0.0&quot;,
-    &quot;@angular/compiler&quot;: &quot;^14.0.0&quot;,
+    &quot;@angular/compiler&quot;: &quot;^19.2.17&quot;,
     &quot;@angular/core&quot;: &quot;^14.0.0&quot;,
     &quot;@angular/fire&quot;: &quot;^7.1.0&quot;,
</file context>
Fix with Cubic

"@angular/core": "^14.0.0",
"@angular/fire": "^7.1.0",
"@angular/forms": "^14.0.0",
Expand Down