Add turnstile token to subscription#810
Open
cocomarine wants to merge 8 commits intomainfrom
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Test coverage89.84% line coverage reported by SimpleCov. |
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Cloudflare Turnstile bot-protection to the subscriptions endpoint by accepting a turnstile_token in the request and verifying it server-side (with fail-open behavior on upstream/network errors), supporting issue RaspberryPiFoundation/digital-editor-issues#1353.
Changes:
- Add
turnstile_tokento subscription request payloads and add request specs covering success/failure/fail-open scenarios. - Add Turnstile verification
before_actiontoApi::SubscriptionsController#createusing Cloudflare’s siteverify endpoint. - Add application configuration and example env var for the Turnstile secret key and enablement flag.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
spec/requests/api/subscriptions_spec.rb |
Extends subscription request payload and adds Turnstile integration request specs (failure + fail-open cases). |
app/controllers/api/subscriptions_controller.rb |
Enforces Turnstile verification (when enabled) before processing subscription creation. |
config/application.rb |
Adds config.x.cloudflare_turnstile secret + enablement derived from env. |
.env.example |
Documents CLOUDFLARE_TURNSTILE_SECRET_KEY for local/testing setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1353
(frontend PR: https://github.com/RaspberryPiFoundation/editor-standalone/pull/859)
Notes
CLOUDFLARE_TURNSTILE_SECRET_KEYto config var using terraform