Report a failed v3 search in the red error style - #5
Merged
Conversation
An empty search in v3 now reads as an error rather than a grey panel title: the field border goes red and the standard error message, "No results found", sits under the field, above "Use my current location". The options panel still follows, now headed "Try searching another way", so the error states the problem and the panel offers the ways on. It covers both failure paths — the address search and a failed landmark or Plus Code search. Behind a new noResultsAsError prop, so only v3 changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty search in v3 now reads as an error rather than a grey panel title: the field border goes red and the standard error message, "No results found", sits under the field, above "Use my current location".
The options panel still follows, now headed "Try searching another way", so the error states the problem and the panel offers the ways on. It covers both failure paths — the address search and a failed landmark or Plus Code search.
Behind a new noResultsAsError prop, so only v3 changes.