Conversation
lizschwab
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR adds support for writing tests for core Blockly in Typescript, and converts some of the existing tests that are trivially convertible. It also resolves a few bugs related to calling
newon non-constructors in the JS tests that TSC surfaced.Once this is merged, we can and should begin gradually converting the remainder of the test suite to Typescript, and use Typescript for all newly-introduced test files. A few notes regarding best practices:
thisto share state between setup and tests. Instead, they should declare variables at the top-level suite, assign them in setup, and reference them in tests. This ensures that everything typechecks; lint will yell at you if you try to tack things on tothis.sharedTestTeardown()import * as Blockly from '#core/blockly.js';as well as importing sinon and chai where needed. If a TS test exercises something that is not exported from core, they may import it by path relative to#core. In general, this pattern should address Use Blockly consistently in mocha tests #7224 once the entire suite is converted – always import and use Blockly, unless testing something that isn't exported, in which case import it directly.Reason for Changes
Better typechecking catches bugs and forces us to be less sloppy in our tests.