fix wrong and bad comments#2838
Conversation
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny from new account / low public contribution graph, mitigated by repo write permission; no Gittensor association found; branch fix-wrong-and-bad-comments -> devnet-ready. FindingsNo findings. ConclusionStatic review found documentation/comment corrections plus a runtime 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN by allowlist/heuristic; author account is very new but has repo write permission, so review focused on whether the comment-only changes accurately describe existing behavior. PR body was empty/trivial; the Auditor has auto-filled it. Please review. Static audit found documentation/comment corrections plus the expected No duplicate PR appeared to be a better candidate; the overlapping PRs are broader feature/deployment/SDK changes rather than competing documentation fixes. I ran FindingsNo findings. ConclusionApprove: the PR is narrow, comment-only aside from the version bump, and the corrected comments align with the current code paths reviewed. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Summary
This PR corrects inaccurate or stale comments in Subtensor runtime, pallet, mock, and test files. The updates clarify current behavior around TAO weight scaling, set-weights normalization, childkey take scaling, owner cut auto-lock defaults, subnet netuid terminology, and default mock/runtime parameter comments.
Files of Interest
pallets/subtensor/src/macros/dispatches.rs: Updates set-weights and childkey take rustdoc to describe max-upscaledu16values rather than percentage/sum-based semantics.pallets/subtensor/src/staking/stake_utils.rs: Rewords TAO weight/stake comments to match the actual storage and stake-combination logic.pallets/subtensor/src/lib.rs: Corrects default-value comments forDefaultTrue,DefaultCKBurn, andOwnerCutAutoLockEnabled.runtime/src/lib.rs,chain-extensions/src/mock.rs,eco-tests/src/mock.rs, and pallet test mocks: Correct TAO weight percentage comments.runtime/src/lib.rs: Bumpsspec_versionfrom 426 to 427 for the devnet-ready runtime change.Behavioral Impact
No executable logic is changed. The PR only updates comments/rustdoc and the runtime
spec_version.Migration / Spec Version
No storage migration is introduced.
spec_versionis bumped to 427.Testing
No runtime tests were added or run because the implementation logic is unchanged. Static review confirmed the edited comments match the nearby code paths.