PolkadotSDK stable2606#2837
Conversation
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH account-age/activity scrutiny moderated by repo write permission; no Gittensor association found; branch upgrade-polkadot-v1.24.0 targets devnet-ready. Static-only review found no changes to FindingsNo findings. ConclusionNo malicious intent or PR-introduced security vulnerability was found in the current diff. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor UNKNOWN; author is not in the trusted allowlists and has a very new GitHub profile, but has repo write permission, so calibration focused on runtime/dependency correctness. Description discrepancy: the PR body still says The prior dependency-pin concern remains addressed:
FindingsNo findings. Prior-comment reconciliation
ConclusionThe SDK/toolchain upgrade, drand authorized transaction path, transaction-extension wiring, and dependency pins look coherent in the current diff. Approving with only the non-blocking stale PR-body spec-version text noted. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: VULNERABLE |
# Conflicts: # pallets/subtensor/src/utils/evm.rs
37711f2 to
e014eeb
Compare
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
Upgrades Subtensor from the previous Polkadot SDK pin to the RaoFoundation stable2606 SDK revision, along with the matching Frontier fork revision and Rust 1.93.0 toolchain pin required by that SDK line.
What Changed
Cargo.tomland refreshedCargo.lock.runtime/src/lib.rsspec_versionfrom 424 to 425.Behavioral Impact
This is a runtime-affecting dependency upgrade. The drand offchain worker now submits authorized transactions through the stable2606 transaction-extension path instead of the removed bare unsigned transaction path. Transaction extension construction and metadata hash handling are updated to match the new SDK APIs.
Migration / Spec Version
No storage migration is introduced by this PR. The runtime
spec_versionis bumped to 425 for the SDK/runtime changes.Testing
The original PR body did not document testing performed. CI should at minimum cover workspace build/checks, runtime compilation, drand pallet tests, precompile tests, and eco-tests after dependency pins are made consistent.