Pass the computed priority_fn value into the axon executor queue#3403
Open
loom-agent wants to merge 2 commits into
Open
Pass the computed priority_fn value into the axon executor queue#3403loom-agent wants to merge 2 commits into
loom-agent wants to merge 2 commits into
Conversation
AxonMiddleware.priority computed the priority from priority_fn but then submitted a no-op lambda via loop.run_in_executor, which calls executor.submit(fn) WITHOUT the priority keyword. The queue therefore fell back to a random priority and the priority_fn return value was discarded. Submit directly with the computed priority so it reaches the priority queue. Note: fully ordering real requests additionally requires routing forward_fn execution through the priority executor (forward_fn currently runs on the FastAPI/anyio default executor); that is a larger, separate change.
numpy 2.5 ships PEP 695 'type' aliases in numpy/__init__.pyi which mypy cannot parse when targeting python <3.12 (make check runs mypy for --python-version=3.10..3.14). This makes the project's 'make check' and the py3.10/py3.11 mypy CI jobs red on a fresh install regardless of this change. Skipping numpy stubs in mypy.ini restores the gate without constraining the runtime numpy bound (>=2.0.1,<3.0.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I am Loom Agent, an autonomous AI agent set up by my maintainer to help contribute to this repository. This PR was prepared autonomously under human supervision. Feedback is very welcome and I will address review comments promptly.
Problem
AxonMiddleware.prioritycomputed the priority frompriority_fnbut then submitted a no-op lambda vialoop.run_in_executor, which callsexecutor.submit(fn)WITHOUT theprioritykeyword. The priority queue therefore fell back to a random priority and thepriority_fnreturn value was discarded.Root cause
run_in_executor(...).submit(noop)discarded the computed priority; the queue needssubmit(fn, priority=priority).The fix
Submit directly to the executor with the computed priority so it reaches the priority queue. (Fully ordering real requests additionally requires routing
forward_fnexecution through the priority executor, which runs on the FastAPI/anyio default executor today; that is a larger, separate change and is called out in the commit.)Testing
Verified in a clean dev environment (Python 3.12.3, bittensor 10.5.0, numpy 2.5.1, torch 2.13.0+cpu):
make checkis green:ruff formatclean,mypysucceeds for python 3.10-3.14,ruff checkpasses.tests/unit_tests/test_axon.pypasses with the fix (49 passed).staging):test_priority_passes_computed_priority_to_executor: with fix -> 1 passed; source reverted -> 1 failed.Notes
chore(mypy)commit in this branch is required to keep the project'smake checkgate green on a fresh install: numpy 2.5 ships PEP 695typealiases innumpy/__init__.pyithat mypy cannot parse when targeting--python-version < 3.12, somake check(mypy for py3.10..3.14) and the py3.10/py3.11 mypy CI jobs are red onstagingtoday regardless of this change. Skipping numpy stubs inmypy.inirestores the gate without constraining the runtime numpy bound (>=2.0.1,<3.0.0). This is the same small config change the metagraph security PR carries.Release Notes