Skip to content

Fix gosec shell alias finding #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aksOps merged 1 commit into from
Jun 4, 2026
Merged

Fix gosec shell alias finding #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/adapter/tmux_adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func shellAliasCommand(ctx context.Context, cmd []string) ([]string, error) {
if !filepath.IsAbs(shell) {
return nil, fmt.Errorf("invalid SHELL %q: must be absolute for command alias fallback", shell)
}
check := exec.CommandContext(ctx, shell, "-ic", "type "+tmux.ShellJoin([]string{cmd[0]})+" >/dev/null 2>&1") // #nosec G204 -- shell is the user's configured absolute shell; alias name is validated before reaching this path.
check := exec.CommandContext(ctx, shell, "-ic", "type "+tmux.ShellJoin([]string{cmd[0]})+" >/dev/null 2>&1") // #nosec G204,G702 -- shell is the user's configured absolute shell; alias name is validated and shell-quoted before reaching this path.
if err := check.Run(); err != nil {
return nil, fmt.Errorf("command alias %q not found on PATH or in interactive shell: %w", cmd[0], err)
}
Expand Down
Loading