test(vectorindex): skip Recall10k under -race#32
Merged
Conversation
TestHNSW_Recall10k is the CI bottleneck at ~410s under -race (68% of the integration job). The workload is fully sequential — build 10k vectors, then 20 query probes — so the race detector has nothing to catch and just adds ~10× overhead. Added a raceEnabled build-tagged constant (standard Go idiom) so the test skips only under -race. TestHNSW_ConcurrentAddSearch still runs under -race and covers the actual concurrent code path. Local timings: go test -run Recall10k 68s (recall=1.000) go test -race -run Recall10k 1s (skip) go test -race -run ConcurrentAdd 2s (unchanged) Integration CI projected: 600s → ~190s. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`TestHNSW_Recall10k` was the integration-CI bottleneck at ~410s (68% of the 10-min job). Workload is 100% sequential — the race detector has nothing to catch and just adds ~10× overhead.
Fix: standard `raceEnabled` build-tagged constant; skip only this test under `-race`. `TestHNSW_ConcurrentAddSearch` still runs under `-race` and covers the actual concurrent path.
Local timings
CI impact
Integration job: ~600s → ~190s (~7 min saved per run).
Test plan