Polish Linux (Proton) support: review fixes, CI, docs, messaging - #4
Merged
Conversation
Follow-up to the native Linux port (PR #2). Covers the review fixes, Linux-aware messaging, CI coverage, and docs so the build-from-source Linux path is correct and honest. Windows behavior is unchanged (platform-gated; Windows UI strings are byte-for-byte identical). Code fixes (Linux AF_PACKET backend): - Reuse a single 256 KiB recv buffer instead of a fresh zeroed allocation per frame; copy out only the captured bytes. - Interface description now includes the name, so the adapter picker shows e.g. "eth0 (link up)" instead of a bare "link up" identical for every live NIC. - Only offer the Npcap capture method on Windows; off Windows the sole backend is the raw socket, so selecting Npcap (whose load() bails) is no longer possible. - Add examples/capture_smoke.rs (referenced by docs/LINUX.md): lists interfaces, opens one, reports captured frames + TCP/443 segments. Platform-aware messaging (Windows text unchanged; new Linux variants added to every locale): - Elevation prompt: "run as administrator" -> capture-permission wording / "Grant capture access" (Linux gates capture behind CAP_NET_RAW, not Administrator). - Synced screens: drop "stays in the tray" (no tray on Linux; closing the window quits). - Capture method label: "Windows raw sockets" -> "Raw sockets (AF_PACKET)". - Language default: "Match Windows" -> "Match system". - Hide the tray-only Startup settings card off Windows. - Don't run the self-updater off Windows: the installer extracts arctracker-sync.exe, which a source-built Linux binary never matches. - Gate #![windows_subsystem] with cfg_attr(windows). The 7 new Linux UI strings are translated into all 19 non-English locales (no English fallback). CI and docs: - Add an ubuntu-latest CI job (clippy -D warnings + build + full test suite; Linux has no requireAdministrator manifest so it runs the tests, not just compiles them). - README: Linux-aware intro, a build-from-source Linux section, and a "why it needs elevation" section covering both Administrator and CAP_NET_RAW. Verified: Windows clippy -D warnings clean; Linux fresh build clean and all 67 tests pass; capture_smoke captures live TCP/443; all locale files are valid JSON and load at build time.
mattmarcin
force-pushed
the
linux-followup
branch
from
June 12, 2026 17:51
270cf8b to
75b6116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the native Linux port (#2). Makes the build-from-source Linux path correct and honest, and adds the CI/docs/messaging that #2 didn't include. Windows behavior is unchanged — everything is platform-gated and the Windows UI strings are byte-for-byte identical.
Code fixes (Linux AF_PACKET backend)
eth0 (link up)) instead of a barelink upidentical for every NIC.load()bails).examples/capture_smoke.rs(referenced bydocs/LINUX.md).Platform-aware messaging
Windows text unchanged; new Linux variants added to every locale (the 7 new strings are translated into all 19 non-English locales, no English fallback).
CAP_NET_RAW, not Administrator).arctracker-sync.exe, which a source build never matches).#![windows_subsystem]withcfg_attr(windows).CI and docs
-D warnings+ build + full test suite (Linux runs the tests, not just compiles them).CAP_NET_RAW.Verification
clippy -D warnings: clean.capture_smokecaptures live TCP/443 in a Linux container.Not in scope / known gaps
SSLKEYLOGFILE→ decrypt → sync has not been confirmed on a real Linux box with the game. Treat Linux as experimental until that smoke test passes.sr.json(sledećу, a stray Cyrillic letter insyncedIdle.body) — left as-is since it predates this branch; worth a separate fix.