fix: preserve nullable null branches in generated rewrites - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve nullable null branches in generated rewrites
Summary
Fix generated
CS8600warnings in the Experiment project without restoring nullable-warning suppression.The null-conditional Rewrite path previously emitted a null branch cast to a non-nullable reference type when Roslyn reported a non-nullable converted type. That produced generated syntax such as:
The rewriter now preserves the nullable result type of the conditional access:
This is type-correct for a null-conditional branch and avoids warnings without adding
!ornull!.Changes
Validation
dotnet build AlephMapper.slnx --configuration Release— 0 warnings, 0 errorsdotnet test AlephMapper.slnx --configuration Release— 97 passed