Skip to content

Enhance resume print styles - #15

Merged
RadValentin merged 6 commits into
masterfrom
13-resume-print-styles
Sep 11, 2026
Merged

RadValentin merged 6 commits into
masterfrom
13-resume-print-styles

Conversation

@RadValentin

@RadValentin RadValentin commented Sep 11, 2026 •

Copy link
Copy Markdown
Owner

Fixes #13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regenerate and commit the downloadable PDF, and adjust the mobile language grid to prevent narrow-screen overflow.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Improves /resume print styling, Markdown project highlights, and resume content.

Changes:

  • Refines print, spacing, visibility, and responsive layout styles.
  • Adds Markdown rendering with marked.
  • Updates resume content and language entries.
File summaries
File Summary
src/styles/resume.css Updates print and responsive language-grid styling.
src/pages/resume.astro Adds print visibility classes and Markdown rendering.
src/data/resume.json Updates resume content and language details.
package.json Adds the marked dependency.
package-lock.json Locks the new dependency.
Review details

Suppressed comments (3)

src/data/resume.json:9

  • This PR changes the web resume content, but the corresponding src/assets/valentin-radulescu-resume.pdf is not included in the PR. The downloadable resume will therefore remain stale relative to the revised summary, experience wording, and language list; regenerate and commit the PDF alongside these changes.
    "summary": "Front-end engineer with 9 years of experience building user interfaces and the systems that support them. Developed Skype's messaging interface with React Native and helped build Hootsuite Analytics from the ground up with React. Took a career break from 2022 to 2025 while pursuing a BSc in Computer Science. Now seeking new front-end opportunities and open to office-based roles, relocation, or remote work.",

src/pages/resume.astro:144

  • This PR changes the resume page, styles, and data, but the updated src/assets/valentin-radulescu-resume.pdf is not included in the diff. Because this page still links that asset as the downloadable PDF, users will receive a stale document that omits these content and layout changes. Please regenerate and commit the PDF with these changes (and consider automating generation).
              {pro.highlights.map(h => <li set:html={marked.parseInline(h)} />)}

src/styles/resume.css:43

  • This PR changes the web resume's print styles, but the downloadable src/assets/valentin-radulescu-resume.pdf is not included in the changed files. Because /resume still links to that static PDF, users will receive a stale resume; please regenerate and commit the PDF (or generate it from the HTML).
  html {
    font-size: 10pt;
  }
  • Files reviewed: 4/6 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/styles/resume.css
@RadValentin
RadValentin merged commit 2edf54d into master Sep 11, 2026
4 checks passed
@RadValentin
RadValentin deleted the 13-resume-print-styles branch September 11, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate resume from HTML

2 participants