Enhance resume print styles - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Regenerate and commit the downloadable PDF, and adjust the mobile language grid to prevent narrow-screen overflow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves /resume print styling, Markdown project highlights, and resume content.
Changes:
- Refines print, spacing, visibility, and responsive layout styles.
- Adds Markdown rendering with
marked. - Updates resume content and language entries.
File summaries
| File | Summary |
|---|---|
src/styles/resume.css |
Updates print and responsive language-grid styling. |
src/pages/resume.astro |
Adds print visibility classes and Markdown rendering. |
src/data/resume.json |
Updates resume content and language details. |
package.json |
Adds the marked dependency. |
package-lock.json |
Locks the new dependency. |
Review details
Suppressed comments (3)
src/data/resume.json:9
- This PR changes the web resume content, but the corresponding
src/assets/valentin-radulescu-resume.pdfis not included in the PR. The downloadable resume will therefore remain stale relative to the revised summary, experience wording, and language list; regenerate and commit the PDF alongside these changes.
"summary": "Front-end engineer with 9 years of experience building user interfaces and the systems that support them. Developed Skype's messaging interface with React Native and helped build Hootsuite Analytics from the ground up with React. Took a career break from 2022 to 2025 while pursuing a BSc in Computer Science. Now seeking new front-end opportunities and open to office-based roles, relocation, or remote work.",
src/pages/resume.astro:144
- This PR changes the resume page, styles, and data, but the updated
src/assets/valentin-radulescu-resume.pdfis not included in the diff. Because this page still links that asset as the downloadable PDF, users will receive a stale document that omits these content and layout changes. Please regenerate and commit the PDF with these changes (and consider automating generation).
{pro.highlights.map(h => <li set:html={marked.parseInline(h)} />)}
src/styles/resume.css:43
- This PR changes the web resume's print styles, but the downloadable
src/assets/valentin-radulescu-resume.pdfis not included in the changed files. Because/resumestill links to that static PDF, users will receive a stale resume; please regenerate and commit the PDF (or generate it from the HTML).
html {
font-size: 10pt;
}
- Files reviewed: 4/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13