ENH: Add lychee link checker#954
Open
axel-grc wants to merge 1 commit into
Open
Conversation
following ITK PR InsightSoftwareConsortium/ITK#5377
SimonRit
approved these changes
Jun 4, 2026
SimonRit
left a comment
SimonRit
left a comment
Collaborator
There was a problem hiding this comment.
Fine with me, I just have comments to potentially improve it
| # Limit lychee's recursive scan to documentation-style file extensions; | ||
| # skipping the vendored ThirdParty trees keeps run time tractable and | ||
| # avoids vendored README links that are not maintained by ITK. | ||
| extensions = ["md", "rst", "txt", "html"] |
Collaborator
There was a problem hiding this comment.
why not test links in .h and .cxx files?
| @@ -0,0 +1,60 @@ | |||
| # Configuration for Utilities/Maintenance/check-links.sh. | |||
Collaborator
There was a problem hiding this comment.
When is this executed? The PR didn't trigger any check it seems.
Collaborator
There was a problem hiding this comment.
It looks like we can easily run it with pre-commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following ITK PR InsightSoftwareConsortium/ITK#5377
Close #942