Skip to content

Examples 3D+time#883

Open
cyrilmory wants to merge 1 commit into
RTKConsortium:mainfrom
cyrilmory:examples_3d_time
Open

Examples 3D+time#883
cyrilmory wants to merge 1 commit into
RTKConsortium:mainfrom
cyrilmory:examples_3d_time

Conversation

@cyrilmory

Copy link
Copy Markdown
Contributor

This PR moves the code generating the data for 3D+time tests and examples into a helper function, which can be reused.
The changes are currently applied only to rtkfourdroostertest.cxx, but can be propagated to the other 3D+time tests.
The PR also adds the 4D conjugate gradient C++ example, using the helper function to generate the data.

If it is fine for you, I will add the other examples as additional commits on this same PR.

@SimonRit

SimonRit commented Jan 8, 2026

Copy link
Copy Markdown
Collaborator

Thanks. I'm no so fond of having source files out of the example folder, I prefer to have them self contained. I would prefer to have one example to generate the data, a copy of which could be provided on girder, and then other examples to use the generated data. Would that be doable?

@cyrilmory

Copy link
Copy Markdown
Contributor Author

Yes, that's doable. And would you keep the helper function for the tests, or get rid of it entirely ?

@SimonRit

SimonRit commented Jan 8, 2026

Copy link
Copy Markdown
Collaborator

Yes, that's doable. And would you keep the helper function for the tests, or get rid of it entirely ?

You can keep it for the tests if it's useful, we've done it with other codes.

@cyrilmory

Copy link
Copy Markdown
Contributor Author

Is is better now ? If so, I'll proceed with the other 3D+time examples

@cyrilmory cyrilmory force-pushed the examples_3d_time branch 2 times, most recently from ede210c to b928a5f Compare January 19, 2026 11:23
@cyrilmory cyrilmory force-pushed the examples_3d_time branch 3 times, most recently from dad9771 to c9f0526 Compare February 5, 2026 11:26
@SimonRit SimonRit self-assigned this Apr 16, 2026
@SimonRit SimonRit added this to the RTK 3.0 milestone Apr 16, 2026
@SimonRit SimonRit force-pushed the examples_3d_time branch 3 times, most recently from 2ea94f5 to 9163aab Compare June 5, 2026 15:59
@SimonRit

SimonRit commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

I have rebased and then made several modifications to this PR:
https://github.com/RTKConsortium/RTK/compare/bb76a114c163591771c2300ef18b38554795bb10..9163aab7a33048b22e97914cff522f7a6d3580b5

@axel-grc Can you please take over and

  • Check that the test run
  • Add images in the documentation
  • Translate the examples to Python
    ? Thanks!

@SimonRit SimonRit assigned axel-grc and unassigned SimonRit Jun 5, 2026
@SimonRit SimonRit force-pushed the examples_3d_time branch from 9163aab to 95c6923 Compare June 7, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants