Examples 3D+time#883
Conversation
de87bef to
a7e0c1f
Compare
|
Thanks. I'm no so fond of having source files out of the example folder, I prefer to have them self contained. I would prefer to have one example to generate the data, a copy of which could be provided on girder, and then other examples to use the generated data. Would that be doable? |
|
Yes, that's doable. And would you keep the helper function for the tests, or get rid of it entirely ? |
You can keep it for the tests if it's useful, we've done it with other codes. |
a7e0c1f to
ead2406
Compare
|
Is is better now ? If so, I'll proceed with the other 3D+time examples |
ede210c to
b928a5f
Compare
dad9771 to
c9f0526
Compare
2ea94f5 to
9163aab
Compare
|
I have rebased and then made several modifications to this PR: @axel-grc Can you please take over and
|
9163aab to
95c6923
Compare
This PR moves the code generating the data for 3D+time tests and examples into a helper function, which can be reused.
The changes are currently applied only to rtkfourdroostertest.cxx, but can be propagated to the other 3D+time tests.
The PR also adds the 4D conjugate gradient C++ example, using the helper function to generate the data.
If it is fine for you, I will add the other examples as additional commits on this same PR.