Skip to content

Add full Python example#75

Merged
SimonRit merged 1 commit into
RTKConsortium:mainfrom
acoussat:python-example
Jun 3, 2026
Merged

Add full Python example#75
SimonRit merged 1 commit into
RTKConsortium:mainfrom
acoussat:python-example

Conversation

@acoussat

@acoussat acoussat commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Add a new Python example that illustrate the full reconstruction workflow, from the GATE simulation until the final FDK reconstruction.

This is the sibling PR of OpenGATE/opengate#895. I think it should be merged after OpenGATE/opengate#895 (maybe even after it makes it to a GATE release?).

Perhaps now would be a good time to add the mechanisms to execute examples during the CI, like it is done in RTK. @axel-grc would that be a lot of work? Would you have time to have a look into it? It would probably be much faster for your to do it than for me.

Also, do we want to add the source code directly into the documentation, as it is done in RTK?

Final question, do we want the same example implemented in bash? Could be useful in the documentation.

@SimonRit

Copy link
Copy Markdown
Collaborator

Add a new Python example that illustrate the full reconstruction workflow, from the GATE simulation until the final FDK reconstruction.

This is the sibling PR of OpenGATE/opengate#895. I think it should be merged after OpenGATE/opengate#895 (maybe even after it makes it to a GATE release?).

After it's merged, not after it makes it to a GATE release as it's likely in a long time (https://github.com/OpenGATE/openGate/tags).

Perhaps now would be a good time to add the mechanisms to execute examples during the CI, like it is done in RTK. @axel-grc would that be a lot of work? Would you have time to have a look into it? It would probably be much faster for your to do it than for me.

Yes

Also, do we want to add the source code directly into the documentation, as it is done in RTK?

Yes, what do you think?

Final question, do we want the same example implemented in bash? Could be useful in the documentation.

Yes but can be a follow-up PR.

@SimonRit

Copy link
Copy Markdown
Collaborator

Perhaps now would be a good time to add the mechanisms to execute examples during the CI, like it is done in RTK. @axel-grc would that be a lot of work? Would you have time to have a look into it? It would probably be much faster for your to do it than for me.

I would suggest to avoid the generation of the data in this full example at testing. This could be done by downloading the data from Girder before running the full example and reading the files from disk if they already exist instead of running a Gate simu.

@acoussat

Copy link
Copy Markdown
Collaborator Author

Like for #81, we will run the GATE simulations directly on the self-hosted runner.

@acoussat

acoussat commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

OpenGATE/opengate#895 has been merged, this PR is therefore ready for review.

@acoussat acoussat changed the title WIP: Add full Python example Add full Python example Jun 2, 2026
@acoussat acoussat requested a review from SimonRit June 2, 2026 09:36

@SimonRit SimonRit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions. Can you implement them before merging please?

Comment thread documentation/docs/getting_started.md Outdated
Add a new Python example that illustrate the full reconstruction workflow, from the GATE simulation until the final FDK reconstruction.
@acoussat acoussat requested a review from SimonRit June 3, 2026 08:48
@SimonRit SimonRit merged commit 0a33be5 into RTKConsortium:main Jun 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants