You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
examples/network/udpclient.c has an argument parsing issue in the --cnt handling path.
The current code checks argc == 7 but then reads argv[7], and it also checks the --cnt option at the wrong index.
For invalid command formats, this can lead to out-of-bounds access during argument parsing.
What is your solution
Restrict the normal -h <host> -p <port> path to valid argument counts only
Fix the --cnt option index from argv[6] to argv[5]
Fix the count value index from argv[7] to argv[6]
Reject malformed 7-argument input by falling back to usage output
Provide the config and bsp
BSP: N/A
.config: N/A
action: N/A
Verification
Reviewed the updated parsing flow for:
udpclient --help
udpclient --stop
udpclient -h <host> -p <port>
udpclient -h <host> -p <port> --cnt <count>
Verified the new logic no longer reads beyond the valid argv range for the --cnt path
Verified the diff only updates examples/network/udpclient.c
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!
为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).
设置需排除的文件/目录(目录请以"/"结尾)
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to:fix-udpclient-cnt-parse
设置PR number为 \ Set the PR number to:11527
等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.
完成后,提交将自动更新至 fix-udpclient-cnt-parse 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix-udpclient-cnt-parse branch automatically, and the related Pull Request will be updated.
如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
itxwh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why to submit this PR
examples/network/udpclient.chas an argument parsing issue in the--cnthandling path.The current code checks
argc == 7but then readsargv[7], and it also checks the--cntoption at the wrong index.For invalid command formats, this can lead to out-of-bounds access during argument parsing.
What is your solution
-h <host> -p <port>path to valid argument counts only--cntoption index fromargv[6]toargv[5]argv[7]toargv[6]Provide the config and bsp
Verification
udpclient --helpudpclient --stopudpclient -h <host> -p <port>udpclient -h <host> -p <port> --cnt <count>argvrange for the--cntpathexamples/network/udpclient.c