Skip to content

[ci]detect assertion failures in QEMU utest logs#11520

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:fix-utest-qemu-assert-ci
Jun 26, 2026
Merged

[ci]detect assertion failures in QEMU utest logs#11520
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:fix-utest-qemu-assert-ci

Conversation

@CYFS3

@CYFS3 CYFS3 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

QEMU utest 日志监控当前主要依赖 utest 失败结果和完成标志判断运行状态。发生 RT-Thread 内核断言或 ulog 断言后,系统可能停在调试循环,日志中不会继续输出 utest 完成标志,监控阶段无法及时把断言识别为失败。

你的解决方案是什么 (what is your solution)

  • 从 QEMU 日志文件开头开始读取输出,避免遗漏启动后较早出现的日志。
  • 在 Monitor qemu log 阶段识别 assertion failed 和 assert failed 两类断言输出。
  • 命中断言后立即返回非零状态,使对应 job 直接失败。
  • 异常退出时清理对应 QEMU 进程,减少遗留进程影响。

请提供验证的bsp和config (provide the config and bsp)

本地验证:git diff --check;解析 workflow YAML 成功;抽取 Monitor qemu log 脚本块执行 bash -n 语法检查通过。

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/workflows/utest_auto_run.yml

📊 Current Review Status (Last Updated: 2026-06-26 14:06 CST)

  • Rbb666 Pending Review
  • kurisaW Pending Review
  • supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions Bot added the action github action yml imporve label Jun 26, 2026
@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:fix-utest-qemu-assert-ci
  • 设置PR number为 \ Set the PR number to:11520
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 fix-utest-qemu-assert-ci 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix-utest-qemu-assert-ci branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@CYFS3

CYFS3 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

已追加一个临时验证 commit:\TEMP: verify qemu assertion detection\。\n\n它只在 \A9 :default.cfg\ 这个组合里向 QEMU 日志写入一行标准断言格式,用来确认本 PR 的日志监控能把断言识别为 CI failure。验证完成后会撤销这个临时 commit,最终 PR 只保留正式修复。

@CYFS3 CYFS3 changed the title ci: 识别 QEMU utest 日志中的断言失败 识别 QEMU 单元测试日志中的断言失败 Jun 26, 2026
@CYFS3 CYFS3 changed the title 识别 QEMU 单元测试日志中的断言失败 [ci]detect assertion failures in QEMU utest logs Jun 26, 2026
@CYFS3 CYFS3 marked this pull request as ready for review June 26, 2026 05:20
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@CYFS3

CYFS3 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

已撤销上一版无效的临时验证 commit,并追加新的临时验证 commit:\TEMP: simulate qemu assertion log\。\n\n新的验证方式是在 \A9 :default.cfg\ 的 \QEMU Run Test\ 阶段直接生成一份包含断言行的 \qemu_output_arm.log\,然后交给后续 \Monitor qemu log\ 识别,更接近真实 QEMU 日志触发路径。验证完成后撤销这颗临时 commit 即可。

@CYFS3 CYFS3 force-pushed the fix-utest-qemu-assert-ci branch from ee6906c to 8be0c1e Compare June 26, 2026 05:59
@github-actions github-actions Bot added the Kernel PR has src relate code label Jun 26, 2026
@CYFS3 CYFS3 force-pushed the fix-utest-qemu-assert-ci branch from 8be0c1e to e54c118 Compare June 26, 2026 06:06
@Rbb666 Rbb666 merged commit c374e52 into RT-Thread:master Jun 26, 2026
107 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve Kernel PR has src relate code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants