Skip to content

ci: optimize membrowse target filtering#11518

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:fix/membrowse-trigger-paths
Jun 26, 2026
Merged

ci: optimize membrowse target filtering#11518
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:fix/membrowse-trigger-paths

Conversation

@CYFS3

@CYFS3 CYFS3 commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

MemBrowse Memory Report 当前在 PR/push 触发后会读取完整 .github/membrowse-targets.json，导致即使只修改某一个 BSP（例如 STM32 相关文件），也会对所有 MemBrowse 目标进行构建和内存分析，CI 成本较高且反馈不够聚焦。

你的解决方案是什么 (what is your solution)

  • 为 membrowse-report.yml 增加路径过滤，避免 README、BSP docs、无关 BSP 等改动触发 MemBrowse 报告。
  • 新增 tools/ci/membrowse_filter_targets.py，根据 PR/push 的 changed files 动态筛选 MemBrowse matrix。
  • BSP 单板目录变更只分析对应 target；BSP vendor 共享库/工具目录变更只分析该 vendor 在 matrix 中的 target；components、src、include、libcpu、tools 等公共层变更才保留全量分析。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/stm32/stm32f407-rt-spark（脚本模拟 changed file 验证）

  • .config: 无

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I have considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含 #if 0 代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I have commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用 formatting 等源码格式化工具确保格式符合 RT-Thread 代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到 .github/ALL_BSP_COMPILE.json 详细请参考链接 BSP自查

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：fix/membrowse-trigger-paths
  • 设置PR number为 \ Set the PR number to：11518
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 fix/membrowse-trigger-paths 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/membrowse-trigger-paths branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/membrowse-targets.json
  • .github/workflows/membrowse-report.yml

📊 Current Review Status (Last Updated: 2026-06-26 13:03 CST)

  • ⌛ Rbb666 Pending Review
  • ⌛ kurisaW Pending Review
  • ⌛ supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions Bot added action github action yml imporve tools labels Jun 26, 2026
@CYFS3 CYFS3 marked this pull request as ready for review June 26, 2026 03:07
@CYFS3 CYFS3 force-pushed the fix/membrowse-trigger-paths branch from 1adfd15 to 0fe6b2f Compare June 26, 2026 03:13
@github-actions

github-actions Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

Rbb666
Rbb666 reviewed Jun 26, 2026
View reviewed changes
Comment thread tools/ci/membrowse_filter_targets.py Outdated
)

RELATED_BSP_PREFIXES = (
("bsp/at32/", ("bsp/at32/libraries/", "bsp/at32/tools/")),

@Rbb666 Rbb666 Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块感觉可以抽出来一个json/yml文件，或者在bsp看护基础上添加字段是否需要这个membrowse进行内存检查

@CYFS3 CYFS3 Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块感觉可以抽出来一个json/yml文件，或者在bsp看护基础上添加字段是否需要这个membrowse进行内存检查

同意

@CYFS3 CYFS3 force-pushed the fix/membrowse-trigger-paths branch from 0fe6b2f to a8f9cde Compare June 26, 2026 05:03
@Rbb666 Rbb666 merged commit 64651f9 into RT-Thread:master Jun 26, 2026
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes
@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner
@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner

Assignees

No one assigned

Labels

action github action yml imporve tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CYFS3 @Rbb666